Skip to content

Commit 33751f1

Browse files
meganroggealexr00
andauthored
add GHPR accessibility help (#5936)
* add accessibility help dialog for issues/PR views (#5934) * fix #5933 * Localize, fix errors, remove markdown syntax --------- Co-authored-by: Alex Ross <alros@microsoft.com>
1 parent 5af8268 commit 33751f1

4 files changed

Lines changed: 30 additions & 2 deletions

File tree

package.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"commentingRangeHint",
1818
"commentReactor",
1919
"commentThreadApplicability",
20+
"contribAccessibilityHelpContent",
2021
"contribCommentEditorActionsMenu",
2122
"contribCommentPeekContext",
2223
"contribCommentThreadAdditionalMenu",
@@ -662,13 +663,15 @@
662663
"id": "pr:github",
663664
"name": "%view.pr.github.name%",
664665
"when": "ReposManagerStateContext != NeedsAuthentication && !github:resolvingConflicts",
665-
"icon": "$(git-pull-request)"
666+
"icon": "$(git-pull-request)",
667+
"accessibilityHelpContent": "%view.pr.github.accessibilityHelpContent%"
666668
},
667669
{
668670
"id": "issues:github",
669671
"name": "%view.issues.github.name%",
670672
"when": "ReposManagerStateContext != NeedsAuthentication && !github:resolvingConflicts",
671-
"icon": "$(issues)"
673+
"icon": "$(issues)",
674+
"accessibilityHelpContent": "%view.pr.github.accessibilityHelpContent%"
672675
},
673676
{
674677
"id": "github:conflictResolution",

package.nls.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,10 @@
143143
"view.github.pull.request.name": "GitHub Pull Request",
144144
"view.github.login.name": "Login",
145145
"view.pr.github.name": "Pull Requests",
146+
"view.pr.github.accessibilityHelpContent": {
147+
"message":"Helpful commands include:\n-GitHub Pull Requests: Refresh Pull Requests List\n-GitHub Pull Requests: Focus on Issues View \n-GitHub Pull Requests: Focus on Pull Requests View\n-GitHub Issues: Copy GitHub Permalink\n-GitHub Issues: Create an Issue\n-GitHub Pull Requests: Create Pull Request",
148+
"comment": "Do not translate the contents of (...) or <...> in the message. They are commands that will be replaced with the actual command name and keybinding."
149+
},
146150
"view.issues.github.name": "Issues",
147151
"view.github.conflictResolution.name": "Conflict Resolution",
148152
"view.github.create.pull.request.name": "Create",
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
/*---------------------------------------------------------------------------------------------
2+
* Copyright (c) Microsoft Corporation. All rights reserved.
3+
* Licensed under the MIT License. See License.txt in the project root for license information.
4+
*--------------------------------------------------------------------------------------------*/
5+
6+
// empty placeholder declaration for the `accessibilityHelpContent`-property of the `views`-contribution
7+
8+
// https://github.com/microsoft/vscode/issues/209855 @meganrogge
9+
10+
/**
11+
* View contributions can include an `accessibilityHelpContent` property that provides help content for screen readers
12+
* when the accessibility help dialog is invoked by the user with focus in the view.
13+
*
14+
* The content is provided as a markdown string and can contain commands that will be resolved along with their keybindings.
15+
*/
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
/*---------------------------------------------------------------------------------------------
2+
* Copyright (c) Microsoft Corporation. All rights reserved.
3+
* Licensed under the MIT License. See License.txt in the project root for license information.
4+
*--------------------------------------------------------------------------------------------*/
5+
6+
// empty placeholder declaration for the `editor/content` menu

0 commit comments

Comments
 (0)