Add inline action for start working

And a few linting errors
Fixes #1717

Author: alexr00

package.json

@@ -642,12 +642,14 @@
       {
         "command": "issue.startWorking",
         "title": "Start Working on Issue",
-        "category": "GitHub Issues"
+        "category": "GitHub Issues",
+        "icon": "$(arrow-right)"
       },
       {
         "command": "issue.continueWorking",
         "title": "Continue Working on Issue",
-        "category": "GitHub Issues"
+        "category": "GitHub Issues",
+        "icon": "$(arrow-right)"
       },
       {
         "command": "issue.startWorkingBranchPrompt",
@@ -657,7 +659,8 @@
       {
         "command": "issue.stopWorking",
         "title": "Stop Working on Issue",
-        "category": "GitHub Issues"
+        "category": "GitHub Issues",
+        "icon": "$(primitive-square)"
       },
       {
         "command": "issue.statusBar",
@@ -1009,13 +1012,23 @@
         {
           "command": "issue.openIssue",
           "when": "view =~ /issues:github/ && viewItem =~ /(current|continue)?issue/",
-          "group": "inline"
+          "group": "inline@2"
         },
         {
           "command": "issue.openIssue",
           "when": "view =~ /issues:github/ && viewItem =~ /(current|continue)?issue/",
           "group": "issues_0@0"
         },
+        {
+          "command": "issue.startWorking",
+          "when": "view =~ /issues:github/ && viewItem == issue",
+          "group": "inline@1"
+        },
+        {
+          "command": "issue.startWorking",
+          "when": "view =~ /issues:github/ && viewItem == continueissue",
+          "group": "inline@1"
+        },
         {
           "command": "issue.startWorking",
           "alt": "issue.startWorkingBranchPrompt",
@@ -1037,6 +1050,11 @@
           "when": "view =~ /issues:github/ && viewItem == currentissue",
           "group": "issues_0@2"
         },
+        {
+          "command": "issue.stopWorking",
+          "when": "view =~ /issues:github/ && viewItem == currentissue",
+          "group": "inline@1"
+        },
         {
           "command": "issue.copyIssueNumber",
           "when": "view =~ /issues:github/ && viewItem =~ /(current|continue)?issue/",

src/commands.ts

@@ -29,7 +29,6 @@ import { resolveCommentHandler, CommentReply } from './commentHandlerResolver';
 import { ITelemetry } from './common/telemetry';
 import { TreeNode } from './view/treeNodes/treeNode';
 import { CredentialStore, GitHub } from './github/credentials';
-import { debounce, throttle } from './common/async';
 import { GitAPI } from './typings/git';
 
 const _onDidUpdatePR = new vscode.EventEmitter<PullRequest | undefined>();
@@ -590,12 +589,12 @@ export function registerGlobalCommands(context: vscode.ExtensionContext, gitAPI:
 		let repo: string | undefined;
 
 		const onDidChangeValue = async () => {
-			const repo = sanitizeRepositoryName(quickpick.value);
+			const sanitizedRepo = sanitizeRepositoryName(quickpick.value);
 
-			if (!repo) {
+			if (!sanitizedRepo) {
 				quickpick.items = [];
 			} else {
-				quickpick.items = [{ label: `$(repo) Create private repository`, description: `$(github) ${owner}/${repo}`, alwaysShow: true, repo: repo }];
+				quickpick.items = [{ label: `$(repo) Create private repository`, description: `$(github) ${owner}/${sanitizedRepo}`, alwaysShow: true, repo: sanitizedRepo }];
 			}
 		};
 
@@ -636,7 +635,7 @@ export function registerGlobalCommands(context: vscode.ExtensionContext, gitAPI:
 				private: true
 			});
 
-			const githubRepository = res.data;
+			const createdGithubRepository = res.data;
 
 			progress.report({ message: 'Creating first commit', increment: 25 });
 			const repository = await gitAPI.init(folder.uri);
@@ -648,10 +647,10 @@ export function registerGlobalCommands(context: vscode.ExtensionContext, gitAPI:
 			await repository.commit('first commit', { all: true });
 
 			progress.report({ message: 'Uploading files', increment: 25 });
-			await repository.addRemote('origin', githubRepository.clone_url);
+			await repository.addRemote('origin', createdGithubRepository.clone_url);
 			await repository.push('origin', 'master', true);
 
-			return githubRepository;
+			return createdGithubRepository;
 		});
 
 		if (!githubRepository) {

src/issues/issueFeatureRegistrar.ts

@@ -332,7 +332,7 @@ export class IssueFeatureRegistrar implements vscode.Disposable {
 			} catch (e) {
 				// leave defaults undefined
 			}
-			const stopWorkingText: string = `$(circle-slash) Stop working on #${this._stateManager.currentIssue.issue.number}`;
+			const stopWorkingText: string = `$(primitive-square) Stop working on #${this._stateManager.currentIssue.issue.number}`;
 			const choices = this._stateManager.currentIssue.branchName && defaults ? [openIssueText, pullRequestText, draftPullRequestText, stopWorkingText] : [openIssueText, pullRequestText, draftPullRequestText, stopWorkingText];
 			const response: string | undefined = await vscode.window.showQuickPick(choices, { placeHolder: 'Current issue options' });
 			switch (response) {