Commit 400ee4c
Fix refresh button not fetching latest data due to double-fire race condition
When the refresh button (pr.refreshList) was clicked, two separate
_onDidChangeTreeData events fired on the same CategoryTreeNode instances:
1. forceClearCache() triggered _onDidChangeData → refreshAllQueryResults(true)
2. The pr.refreshList handler itself also called refreshAllQueryResults(true)
This caused VS Code to call getChildren() twice concurrently on the same
nodes. The second call's super.getChildren(true) would dispose the PR
children that the first call had just populated, resulting in the tree
failing to display the fresh data from GitHub.
Fix: Remove _onDidChangeData.fire() from forceClearCache() to eliminate
the duplicate event source, and update pr.refreshList to call
refreshAllQueryResults() without the reset flag (which is a no-op anyway
since forceClearCache() already empties the cache).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent d82874f commit 400ee4c
2 files changed
+1
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
184 | | - | |
185 | 184 | | |
186 | 185 | | |
187 | 186 | | |
| |||
0 commit comments