Support GitHub PR URLs in "Checkout Pull Request by Number" command (#7258)

* Initial plan

* Implement PR checkout by URL support

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Improve validation for PR checkout by URL feature

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Address PR review feedback: extract helper function, add repo validation, revert title

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* return type

* Revert yarn.lock changes

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

Author: Copilot

src/commands.ts

@@ -29,7 +29,7 @@ import { GHPRComment, GHPRCommentThread, TemporaryComment } from './github/prCom
 import { PullRequestModel } from './github/pullRequestModel';
 import { PullRequestOverviewPanel } from './github/pullRequestOverview';
 import { RepositoriesManager } from './github/repositoriesManager';
-import { getIssuesUrl, getPullsUrl, isInCodespaces, vscodeDevPrLink } from './github/utils';
+import { getIssuesUrl, getPullsUrl, isInCodespaces, ISSUE_OR_URL_EXPRESSION, parseIssueExpressionOutput, vscodeDevPrLink } from './github/utils';
 import { isNotificationTreeItem, NotificationTreeItem } from './notifications/notificationItem';
 import { PullRequestsTreeDataProvider } from './view/prsTreeDataProvider';
 import { ReviewCommentController } from './view/reviewCommentController';
@@ -1456,6 +1456,31 @@ ${contents}
 			}
 		}));
 
+	function validateAndParseInput(input: string, expectedOwner: string, expectedRepo: string): { isValid: true; prNumber: number; errorMessage?: string } | { isValid: false; prNumber?: number; errorMessage: string } {
+		const prNumberMatcher = /^#?(\d*)$/;
+		const numberMatches = input.match(prNumberMatcher);
+		if (numberMatches && (numberMatches.length === 2) && !Number.isNaN(Number(numberMatches[1]))) {
+			const num = Number(numberMatches[1]);
+			if (num > 0) {
+				return { isValid: true, prNumber: num };
+			}
+		}
+
+		const urlMatches = input.match(ISSUE_OR_URL_EXPRESSION);
+		const parsed = parseIssueExpressionOutput(urlMatches);
+		if (parsed && parsed.issueNumber && parsed.issueNumber > 0) {
+			// Check if the repository owner and name match
+			if (parsed.owner && parsed.name) {
+				if (parsed.owner !== expectedOwner || parsed.name !== expectedRepo) {
+					return { isValid: false, errorMessage: vscode.l10n.t('Repository in URL does not match the selected repository') };
+				}
+			}
+			return { isValid: true, prNumber: parsed.issueNumber };
+		}
+
+		return { isValid: false, errorMessage: vscode.l10n.t('Value must be a pull request number or GitHub URL') };
+	}
+
 	context.subscriptions.push(
 		vscode.commands.registerCommand('pr.checkoutByNumber', async () => {
 
@@ -1473,21 +1498,24 @@ ${contents}
 			if (!githubRepo) {
 				return;
 			}
-			const prNumberMatcher = /^#?(\d*)$/;
 			const prNumber = await vscode.window.showInputBox({
-				ignoreFocusOut: true, prompt: vscode.l10n.t('Enter the pull request number'),
+				ignoreFocusOut: true, prompt: vscode.l10n.t('Enter the pull request number or URL'),
 				validateInput: (input: string) => {
-					const matches = input.match(prNumberMatcher);
-					if (!matches || (matches.length !== 2) || Number.isNaN(Number(matches[1]))) {
-						return vscode.l10n.t('Value must be a number');
-					}
-					return undefined;
+					const result = validateAndParseInput(input, githubRepo.repo.remote.owner, githubRepo.repo.remote.repositoryName);
+					return result.isValid ? undefined : result.errorMessage;
 				}
 			});
 			if ((prNumber === undefined) || prNumber === '#') {
 				return;
 			}
-			const prModel = await githubRepo.manager.fetchById(githubRepo.repo, Number(prNumber.match(prNumberMatcher)![1]));
+
+			// Extract PR number from input (either direct number or URL)
+			const parseResult = validateAndParseInput(prNumber, githubRepo.repo.remote.owner, githubRepo.repo.remote.repositoryName);
+			if (!parseResult.isValid) {
+				return vscode.window.showErrorMessage(parseResult.errorMessage || vscode.l10n.t('Invalid pull request number or URL'));
+			}
+
+			const prModel = await githubRepo.manager.fetchById(githubRepo.repo, parseResult.prNumber);
 			if (prModel) {
 				return ReviewManager.getReviewManagerForFolderManager(reviewsManager.reviewManagers, githubRepo.manager)?.switch(prModel);
 			}

src/test/issues/issuesUtils.test.ts

@@ -48,5 +48,21 @@ describe('Issues utilities', function () {
 		const notIssue = '#a4';
 		const notIssueParsed = parseIssueExpressionOutput(notIssue.match(ISSUE_OR_URL_EXPRESSION));
 		assert.strictEqual(notIssueParsed, undefined);
+		
+		// Test PR URL parsing
+		const prUrl = 'https://github.com/microsoft/vscode/pull/123';
+		const prUrlParsed = parseIssueExpressionOutput(prUrl.match(ISSUE_OR_URL_EXPRESSION));
+		assert.strictEqual(prUrlParsed?.issueNumber, 123);
+		assert.strictEqual(prUrlParsed?.commentNumber, undefined);
+		assert.strictEqual(prUrlParsed?.name, 'vscode');
+		assert.strictEqual(prUrlParsed?.owner, 'microsoft');
+		
+		// Test HTTP PR URL (without S)
+		const prUrlHttp = 'http://github.com/owner/repo/pull/456';
+		const prUrlHttpParsed = parseIssueExpressionOutput(prUrlHttp.match(ISSUE_OR_URL_EXPRESSION));
+		assert.strictEqual(prUrlHttpParsed?.issueNumber, 456);
+		assert.strictEqual(prUrlHttpParsed?.commentNumber, undefined);
+		assert.strictEqual(prUrlHttpParsed?.name, 'repo');
+		assert.strictEqual(prUrlHttpParsed?.owner, 'owner');
 	});
 });