Avoid associating branches with stale closed PRs (#8727)

* Initial plan

* Fix stale PR association for branches tracking a base branch upstream

Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/c9502930-8af9-4e4b-b72f-ad7cdd228e8d

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Remove incomplete issue URL from comment

Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/c9502930-8af9-4e4b-b72f-ad7cdd228e8d

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Re-check GitHub for open PR even when local metadata exists

Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/dea2457f-3b57-4756-a349-7bd07b19d340

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Remove upstream branch name guard per review feedback

Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/ffe794e4-1828-489c-9ee8-12e97a16d4b4

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Restore previous getPullRequestForBranch behavior

Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/64270c6c-f0b3-401d-ab68-314f7ccd6cf5

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

Author: Copilot

src/view/reviewManager.ts

@@ -584,14 +584,21 @@ export class ReviewManager extends Disposable {
 		}
 
 		let matchingPullRequestMetadata = await this._folderRepoManager.getMatchingPullRequestMetadataForBranch();
-
 		if (!matchingPullRequestMetadata) {
 			Logger.appendLine(`No matching pull request metadata found locally for current branch ${branch.name}`, this.id);
-			if (this._cachedBranchName !== branch.name || await this.hasNewPullRequests()) {
-				matchingPullRequestMetadata = await this.checkGitHubForPrBranch(branch);
-			} else {
-				Logger.appendLine(`Skipping GitHub check for branch ${branch.name}: no new PRs since last check`, this.id);
+		}
+
+		// Always check GitHub for a matching open PR (subject to the new-PRs/branch-change cache),
+		// even when local metadata already exists. If GitHub returns a result, it overwrites the
+		// local metadata via associateBranchWithPullRequest. This allows branches whose local
+		// metadata points to a stale closed PR to recover automatically once an open PR exists.
+		if (this._cachedBranchName !== branch.name || await this.hasNewPullRequests() || !matchingPullRequestMetadata) {
+			const metadataFromGithub = await this.checkGitHubForPrBranch(branch);
+			if (metadataFromGithub) {
+				matchingPullRequestMetadata = metadataFromGithub;
 			}
+		} else {
+			Logger.appendLine(`Skipping GitHub check for branch ${branch.name}: no new PRs since last check`, this.id);
 		}
 		this._cachedBranchName = branch.name;