Skip to content

Commit d52df10

Browse files
author
RMacfarlane
committed
Log complete errors, not formatted errors
1 parent 292d3c9 commit d52df10

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/github/pullRequestManager.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ export class PullRequestManager implements vscode.Disposable {
188188
return Promise.all(potentialRemotes.map(remote => this._githubManager.isGitHub(remote.gitProtocol.normalizeUri()!)))
189189
.then(results => potentialRemotes.filter((_, index, __) => results[index]))
190190
.catch(e => {
191-
Logger.appendLine(`Resolving GitHub remotes failed: ${formatError(e)}`);
191+
Logger.appendLine(`Resolving GitHub remotes failed: ${e}`);
192192
vscode.window.showErrorMessage(`Resolving GitHub remotes failed: ${formatError(e)}`);
193193
return [];
194194
});
@@ -455,7 +455,7 @@ export class PullRequestManager implements vscode.Disposable {
455455
hasAuthenticated = authenticationResult.some(isAuthd => isAuthd);
456456
vscode.commands.executeCommand('setContext', 'github:authenticated', hasAuthenticated);
457457
}).catch(e => {
458-
Logger.appendLine(`serverAuthPromises failed: ${formatError(e)}`);
458+
Logger.appendLine(`serverAuthPromises failed: ${e}`);
459459
});
460460

461461
const repositories: GitHubRepository[] = [];
@@ -848,7 +848,7 @@ export class PullRequestManager implements vscode.Disposable {
848848

849849
return comments;
850850
} catch (e) {
851-
Logger.appendLine(`Failed to get pull request review comments: ${formatError(e)}`);
851+
Logger.appendLine(`Failed to get pull request review comments: ${e}`);
852852
return [];
853853
}
854854
}
@@ -1303,7 +1303,7 @@ export class PullRequestManager implements vscode.Disposable {
13031303
this._telemetry.sendTelemetryEvent('pr.create.success', { isDraft: (params.draft || '').toString() });
13041304
return pullRequestModel;
13051305
} catch (e) {
1306-
Logger.appendLine(`GitHubRepository> Creating pull requests failed: ${formatError(e)}`);
1306+
Logger.appendLine(`GitHubRepository> Creating pull requests failed: ${e}`);
13071307

13081308
/* __GDPR__
13091309
"pr.create.failure" : {
@@ -1340,7 +1340,7 @@ export class PullRequestManager implements vscode.Disposable {
13401340
this._telemetry.sendTelemetryEvent('issue.create.success');
13411341
return issueModel;
13421342
} catch (e) {
1343-
Logger.appendLine(`GitHubRepository> Creating issue failed: ${formatError(e)}`);
1343+
Logger.appendLine(`GitHubRepository> Creating issue failed: ${e}`);
13441344

13451345
/* __GDPR__
13461346
"issue.create.failure" : {

0 commit comments

Comments
 (0)