Coding Agent UI: Closed pull requests are not detected as closed (#8485)

* Coding Agent UI: Closed pull requests are not detected as closed
Fixes #8482

* Copilot PR comments

Author: alexr00

src/github/folderRepositoryManager.ts

@@ -22,6 +22,7 @@ import {
 	convertRESTPullRequestToRawPullRequest,
 	getOverrideBranch,
 	getPRFetchQuery,
+	getStateFromQuery,
 	loginComparator,
 	parseGraphQLPullRequest,
 	teamComparator,
@@ -1353,12 +1354,19 @@ export class FolderRepositoryManager extends Disposable {
 				})))
 				.filter(item => item !== null) as PullRequestModel[];
 
+			// GitHub's search API can return stale results whose state doesn't match the query.
+			// Post-filter to ensure only PRs with the requested state are included.
+			const queryState = getStateFromQuery(categoryQuery);
+			const filteredPullRequests = queryState
+				? pullRequests.filter(pr => pr.state === queryState)
+				: pullRequests;
+
 			Logger.debug(`Fetch pull request category ${categoryQuery} - done`, this.id);
 
 			return {
-				items: pullRequests,
+				items: filteredPullRequests,
 				hasMorePages,
-				totalCount: data.total_count
+				totalCount: data.total_count - (pullRequests.length - filteredPullRequests.length)
 			};
 		} catch (e) {
 			Logger.error(`Fetching pull request with query failed: ${e}`, this.id);

src/github/utils.ts

@@ -13,6 +13,7 @@ import { GitHubRepository, ViewerPermission } from './githubRepository';
 import * as GraphQL from './graphql';
 import {
 	AccountType,
+	GithubItemStateEnum,
 	IAccount,
 	IActor,
 	IGitHubRef,
@@ -1643,6 +1644,28 @@ export function getPRFetchQuery(user: string, query: string): string {
 	return `is:pull-request ${filter} type:pr`;
 }
 
+/**
+ * Parse a GitHub search query for a state qualifier (e.g. `is:open`, `is:closed`, `is:merged`).
+ * Returns the corresponding GithubItemStateEnum if found, or undefined if no state is specified.
+ * GitHub's search API can return stale results that don't match the requested state,
+ * so callers can use this to post-filter.
+ */
+export function getStateFromQuery(query: string): GithubItemStateEnum | undefined {
+	const match = query.match(/(?:^|\s)is:(?<state>open|closed|merged)(?:\s|$)/i);
+	if (!match?.groups?.state) {
+		return undefined;
+	}
+	switch (match.groups.state.toLowerCase()) {
+		case 'open':
+			return GithubItemStateEnum.Open;
+		case 'closed':
+			return GithubItemStateEnum.Closed;
+		case 'merged':
+			return GithubItemStateEnum.Merged;
+	}
+	return undefined;
+}
+
 export function isInCodespaces(): boolean {
 	return vscode.env.remoteName === 'codespaces' && vscode.env.uiKind === vscode.UIKind.Web;
 }