feat: different remotes than `origin` for issues

[Malix-Labs]

As I don't know if this is a broken component or a missing feature, I am unsure if that issue is a bug report or a feature request

Context

Apparently, the githubPullRequests.remotes setting only applies for pull requests and not for issues

Problem

Users wanting to fetch issues from different remotes than origin (e.g. upstream) cannot do that through this extension

Solution

Make it so githubPullRequests.remotes also applies to issues (instead of only for pull requests)

[alexr00]

I can't reproduce this. I'm seeing githubPullRequests.remotes get respected for issues too. Can you share an example repo where you see this happen?

[Malix-Labs]

Well, can you try forking this one and see if you see that upstream issue (#7618) when you checkout the downstream fork repository on VSCode?

It doesn't show up for me

[alexr00]

Can you share the output of git remote -v?

[Malix-Labs]

@alexr00 :

[malix@nixos:~/Repositories/microsoft/vscode-pull-request-github]$ code .

[malix@nixos:~/Repositories/microsoft/vscode-pull-request-github]$ git remote -v
origin  https://github.com/Malix-Labs/vscode-pull-request-github.git (fetch)
origin  https://github.com/Malix-Labs/vscode-pull-request-github.git (push)
upstream        https://github.com/microsoft/vscode-pull-request-github.git (fetch)
upstream        https://github.com/microsoft/vscode-pull-request-github.git (push)

You can see from the above screenshot that only Malix-Labs#1 shows up, which is an issue from my downstream fork of this repository (https://github.com/Malix-Labs/vscode-pull-request-github), and which git points as the origin remote;
Even though this current issue (#7618) should show up given #7618 (comment) proposed behavior

[Malix-Labs]

Also, it's tengential but which type does githubPullRequests.remotes accept?

vscode-pull-request-github/package.json

Lines 178 to 188 in e317a8d

	"githubPullRequests.remotes": {
	"type": "array",
	"default": [
	"origin",
	"upstream"
	],
	"items": {
	"type": "string"
	},
	"markdownDescription": "%githubPullRequests.remotes.markdownDescription%"
	},

vscode-pull-request-github/package.json

Line 185 in e317a8d

"type": "string"

Is it list of strings or list of glob strings?

For example, would:

"githubPullRequests.remotes": [
  "*"
]

work (as in, it would fetch * glob (= all) remotes)?

I think that setting type or description should be enhanced

[alexr00]

Thank you for the details, I see the confusion!

Here's what's happening (not saying it's right, just outlining it):

• PRs view tries to get PRs for your origin (the fork), doesn't find any, so shows PRs from the upstream.
• Issues view tries to get issues for your origin, finds some, so just shows those.

I think for issues we could instead fetch the first page from all remotes since we don't offer the "fetch from other remote" item in the issues view.

[Malix-Labs]

We could also consider having two different remote settings between pull requests and issues, but I think having them merged into a single setting makes more sense and is simpler

we don't offer the "fetch from other remote" item in the issues view.

Maybe it could be interesting to categorize issues by remotes

The alternative is to merge them all into each already existing categories, but then there should also be a way to differentiate at least visually the different remotes