Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR propagates the isOutdated property from review threads to individual comments within those threads, allowing comments to be marked as outdated independently of their position data.
Changes:
- Added
isOutdatedproperty to theICommentinterface - Updated
parseGraphQLCommentto accept and assign theisOutdatedparameter - Modified the outdated comment filter logic to include comments marked as outdated via the new property
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/common/comment.ts | Added optional isOutdated property to the IComment interface |
| src/github/utils.ts | Updated parseGraphQLComment signature to accept isOutdated parameter and pass thread's isOutdated status to comments; updated all call sites |
| src/github/pullRequestModel.ts | Updated all parseGraphQLComment call sites to pass the isOutdated parameter (either from thread or as false for new comments) |
| src/view/reviewManager.ts | Enhanced outdated comment filtering to include comments with isOutdated property in addition to those without position |
| src/test/view/reviewCommentController.test.ts | Added isOutdated: false to test comment fixture to match updated interface |
sandy081
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8401