Sometimes cross-ref event is missing source#8408
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where cross-referenced events from the GitHub API can sometimes be missing the source field, which would cause runtime errors when the code attempted to access properties of the undefined source. The fix makes the source field optional in the GraphQL interface and adds a guard clause to skip processing when source is missing.
Changes:
- Made the
sourcefield optional in the GraphQLCrossReferencedEventinterface - Added null check in
parseCombinedTimelineEventsto skip cross-referenced events without a source
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/github/graphql.ts | Updated CrossReferencedEvent interface to make source field optional |
| src/github/utils.ts | Added guard clause to skip processing cross-referenced events when source is undefined |
aiday-mar
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.