Skip to content

Fix copy link context menu for issue overview #8414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 6 commits into from
Jan 26, 2026
+9 −5
Merged

Fix copy link context menu for issue overview #8414

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68153e2
Initial plan
Copilot Jan 23, 2026
4c8c06e
Initial plan for issue view copy link fix
Copilot Jan 23, 2026
8852122
Add IssueOverview webview to copy link context menu registration
Copilot Jan 23, 2026
4ff224b
Fix copy link commands to also resolve issues
Copilot Jan 23, 2026
811506f
Merge branch 'main' into copilot/fix-copyable-links-in-issue-view
alexr00 Jan 23, 2026
9c5a98e
Remove vscode.dev link option from issue overview context menu
Copilot Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3552,11 +3552,11 @@
},
{
"command": "pr.copyPrLink",
"when": "webviewId == PullRequestOverview && github:copyMenu"
"when": "(webviewId == PullRequestOverview || webviewId == IssueOverview) && github:copyMenu"
},
{
"command": "pr.copyVscodeDevPrLink",
"when": "webviewId == PullRequestOverview && github:copyMenu"
"when": "(webviewId == PullRequestOverview || webviewId == IssueOverview) && github:copyMenu"
},
{
"command": "pr.readyForReviewDescription",
Expand Down
26 changes: 17 additions & 9 deletions src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,32 +1565,40 @@ ${contents}

context.subscriptions.push(
vscode.commands.registerCommand('pr.copyVscodeDevPrLink', async (params: OverviewContext | undefined) => {
let pr: PullRequestModel | undefined;
let item: PullRequestModel | IssueModel | undefined;
if (params) {
pr = await reposManager.getManagerForRepository(params.owner, params.repo)?.resolvePullRequest(params.owner, params.repo, params.number, true);
const folderManager = reposManager.getManagerForRepository(params.owner, params.repo);
item = await folderManager?.resolvePullRequest(params.owner, params.repo, params.number, true);
if (!item) {
item = await folderManager?.resolveIssue(params.owner, params.repo, params.number);
}
} else {
const activePullRequests: PullRequestModel[] = reposManager.folderManagers
.map(folderManager => folderManager.activePullRequest!)
.filter(activePR => !!activePR);
pr = await chooseItem<PullRequestModel>(
item = await chooseItem<PullRequestModel>(
activePullRequests,
itemValue => ({ label: `${itemValue.number}: ${itemValue.title}` }),
{ placeHolder: vscode.l10n.t('Pull request to create a link for') },
);
}
if (pr) {
return vscode.env.clipboard.writeText(vscodeDevPrLink(pr));
if (item) {
return vscode.env.clipboard.writeText(vscodeDevPrLink(item));
}
}));

context.subscriptions.push(
vscode.commands.registerCommand('pr.copyPrLink', async (params: OverviewContext | undefined) => {
let pr: PullRequestModel | undefined;
let item: PullRequestModel | IssueModel | undefined;
Comment thread
alexr00 marked this conversation as resolved.
if (params) {
pr = await reposManager.getManagerForRepository(params.owner, params.repo)?.resolvePullRequest(params.owner, params.repo, params.number, true);
const folderManager = reposManager.getManagerForRepository(params.owner, params.repo);
item = await folderManager?.resolvePullRequest(params.owner, params.repo, params.number, true);
if (!item) {
item = await folderManager?.resolveIssue(params.owner, params.repo, params.number);
}
}
if (pr) {
return vscode.env.clipboard.writeText(pr.html_url);
if (item) {
return vscode.env.clipboard.writeText(item.html_url);
}
}));

Expand Down