Skip to content

Commit 0f39721

Browse files
committed
Partial clean-up, shellstartup Prompt to discuss
1 parent 99adc96 commit 0f39721

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

src/features/terminal/shells/bash/bashStartup.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -76,17 +76,6 @@ async function setupStartup(profile: string, key: string, name: string): Promise
7676
const activationContent = getActivationContent(key);
7777

7878
try {
79-
// Question #1: Ask about the guard, if that is needed in core.
80-
// NEED THE GUARD IN CORE.
81-
82-
// Question #2: I want to check if shell integration script had proper value for VSCODE_BASH_ACTIVATE, and has evaluated that before doing all below?
83-
84-
// VSCODE_PYTHON_ACTIVATE;
85-
86-
// Because if it did, we dont have to bother `insertStartupCode` in user's profile files.
87-
// - We would know shell integration script has proper value of ACTIVATE via checking if that var is non-empty
88-
// - We would know if that has been evaluated if shell integration --> (shell integration script would have ran and evaled, if not we show error)
89-
9079
if (await fs.pathExists(profile)) {
9180
const content = await fs.readFile(profile, 'utf8');
9281
if (hasStartupCode(content, regionStart, regionEnd, [key])) {

0 commit comments

Comments
 (0)