updates

Author: eleanorjboyd

.github/instructions/testing-workflow.instructions.md

@@ -581,3 +581,5 @@ envConfig.inspect
 -   Use `as unknown as TargetType` for type casting instead of `as any` to maintain type safety and avoid 'any' violations
 -   If tests frequently need private access consider that maybe methods should be protected, or public test utilities should exist for testing (1)
 -   When making systematic changes across many similar locations, fix one instance completely first to validate the approach before applying the pattern everywhere (1)
+-   Always recompile tests after making changes before running them, especially when changing imports or type definitions (1)
+-   When using paths as Map keys for tracking, you MUST use Uri.fsPath consistently throughout the test - mixing hardcoded strings with Uri.fsPath causes key mismatches on Windows (1)

src/test/features/terminalEnvVarInjectorBasic.unit.test.ts

@@ -257,6 +257,7 @@ suite('TerminalEnvVarInjector - Core Functionality', () => {
     suite('clearWorkspaceVariables', () => {
         setup(() => {
             injector = new TerminalEnvVarInjector(envVarCollection.object, envVarManager.object);
+            testableInjector = injector as unknown as TerminalEnvVarInjectorTestable;
         });
 
         test('should only delete tracked variables', () => {
@@ -265,7 +266,7 @@ suite('TerminalEnvVarInjector - Core Functionality', () => {
                 MY_VAR: 'value',
                 ANOTHER_VAR: 'value2',
             };
-            testableInjector.applyEnvVarChanges(mockScopedCollection, envVars, '/test/workspace');
+            testableInjector.applyEnvVarChanges(mockScopedCollection, envVars, mockWorkspaceFolder.uri.fsPath);
 
             deleteStub.resetHistory();
 
@@ -281,7 +282,7 @@ suite('TerminalEnvVarInjector - Core Functionality', () => {
         test('should not delete non-tracked variables like BASH_ENV', () => {
             // Mock - Set up only one tracked variable
             const envVars = { MY_VAR: 'value' };
-            testableInjector.applyEnvVarChanges(mockScopedCollection, envVars, '/test/workspace');
+            testableInjector.applyEnvVarChanges(mockScopedCollection, envVars, mockWorkspaceFolder.uri.fsPath);
 
             // Simulate BASH_ENV being set by another manager (not tracked by us)
             getStub.withArgs('BASH_ENV').returns({ value: 'some_bash_command' });