Skip to content

Commit 35d63a1

Browse files
committed
fix: ensure everything compiles
1 parent 43b33a9 commit 35d63a1

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

src/extension.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ export async function activate(context: ExtensionContext): Promise<PythonEnviron
9090
const shellStartupActivationManager = new ShellStartupActivationManagerImpl(
9191
context.environmentVariableCollection,
9292
shellStartupProviders,
93+
shellEnvsProviders,
9394
envManagers,
9495
);
9596
const terminalManager: TerminalManager = new TerminalManagerImpl(terminalActivation, shellEnvsProviders);

src/features/terminal/shells/activateUsingShellStartup.ts

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { ConfigurationChangeEvent, Disposable, GlobalEnvironmentVariableCollection } from 'vscode';
2-
import { getWorkspaceFolder, getWorkspaceFolders, onDidChangeConfiguration } from '../../../common/workspace.apis';
3-
import { getAutoActivationType, setAutoActivationType } from '../utils';
4-
import { ShellScriptEditState, ShellStartupScriptProvider } from './startupProvider';
52
import { DidChangeEnvironmentEventArgs } from '../../../api';
6-
import { EnvironmentManagers } from '../../../internal.api';
7-
import { traceError, traceInfo } from '../../../common/logging';
83
import { ShellStartupActivationStrings } from '../../../common/localize';
4+
import { traceError, traceInfo } from '../../../common/logging';
95
import { showErrorMessage, showInformationMessage } from '../../../common/window.apis';
6+
import { getWorkspaceFolder, getWorkspaceFolders, onDidChangeConfiguration } from '../../../common/workspace.apis';
7+
import { EnvironmentManagers } from '../../../internal.api';
8+
import { getAutoActivationType, setAutoActivationType } from '../utils';
9+
import { ShellEnvsProvider, ShellScriptEditState, ShellStartupScriptProvider } from './startupProvider';
1010

1111
export interface ShellStartupActivationManager extends Disposable {
1212
initialize(): Promise<void>;
@@ -19,6 +19,7 @@ export class ShellStartupActivationManagerImpl implements ShellStartupActivation
1919
constructor(
2020
private readonly envCollection: GlobalEnvironmentVariableCollection,
2121
private readonly shellStartupProviders: ShellStartupScriptProvider[],
22+
private readonly shellEnvsProviders: ShellEnvsProvider[],
2223
private readonly em: EnvironmentManagers,
2324
) {
2425
this.envCollection.description = ShellStartupActivationStrings.envCollectionDescription;
@@ -46,14 +47,14 @@ export class ShellStartupActivationManagerImpl implements ShellStartupActivation
4647
workspaces.forEach((workspace) => {
4748
const collection = this.envCollection.getScoped({ workspaceFolder: workspace });
4849
promises.push(
49-
...this.shellStartupProviders.map((provider) => provider.removeEnvVariables(collection)),
50+
...this.shellEnvsProviders.map((provider) => provider.removeEnvVariables(collection)),
5051
);
5152
});
5253
await Promise.all(promises);
5354
} else {
5455
// User has no workspaces open
5556
await Promise.all(
56-
this.shellStartupProviders.map((provider) => provider.removeEnvVariables(this.envCollection)),
57+
this.shellEnvsProviders.map((provider) => provider.removeEnvVariables(this.envCollection)),
5758
);
5859
}
5960
}
@@ -72,7 +73,7 @@ export class ShellStartupActivationManagerImpl implements ShellStartupActivation
7273
const envVars = this.envCollection.getScoped({ workspaceFolder: wf });
7374
if (envVars) {
7475
await Promise.all(
75-
this.shellStartupProviders.map(async (provider) => {
76+
this.shellEnvsProviders.map(async (provider) => {
7677
if (e.new) {
7778
await provider.updateEnvVariables(envVars, e.new);
7879
} else {
@@ -128,7 +129,7 @@ export class ShellStartupActivationManagerImpl implements ShellStartupActivation
128129
workspaces.forEach((workspace) => {
129130
const collection = this.envCollection.getScoped({ workspaceFolder: workspace });
130131
promises.push(
131-
...this.shellStartupProviders.map(async (provider) => {
132+
...this.shellEnvsProviders.map(async (provider) => {
132133
const env = await this.em.getEnvironment(workspace.uri);
133134
if (env) {
134135
await provider.updateEnvVariables(collection, env);
@@ -141,7 +142,7 @@ export class ShellStartupActivationManagerImpl implements ShellStartupActivation
141142
await Promise.all(promises);
142143
} else {
143144
await Promise.all(
144-
this.shellStartupProviders.map(async (provider) => {
145+
this.shellEnvsProviders.map(async (provider) => {
145146
const env = await this.em.getEnvironment(undefined);
146147
if (env) {
147148
await provider.updateEnvVariables(this.envCollection, env);

0 commit comments

Comments
 (0)