Remove redundant shell activation and deactivation for FISH in getShellActivationCommands (#1097)

eleanorjboyd · web-flow · commit 38f046d38f25 · 2026-01-13T08:15:11.000+01:00
fixes #1096
diff --git a/src/managers/common/utils.ts b/src/managers/common/utils.ts
@@ -176,9 +176,6 @@ export async function getShellActivationCommands(binDir: string): Promise<{
     if (await fs.pathExists(path.join(binDir, 'activate.csh'))) {
         shellActivation.set(ShellConstants.CSH, [{ executable: 'source', args: [path.join(binDir, `activate.csh`)] }]);
         shellDeactivation.set(ShellConstants.CSH, [{ executable: 'deactivate' }]);
-
-        shellActivation.set(ShellConstants.FISH, [{ executable: 'source', args: [path.join(binDir, `activate.csh`)] }]);
-        shellDeactivation.set(ShellConstants.FISH, [{ executable: 'deactivate' }]);
     }
 
     if (await fs.pathExists(path.join(binDir, 'activate.fish'))) {

Original file line number	Diff line number	Diff line change
`@@ -176,9 +176,6 @@ export async function getShellActivationCommands(binDir: string): Promise<{`
`176`	`176`	`if (await fs.pathExists(path.join(binDir, 'activate.csh'))) {`
`177`	`177`	shellActivation.set(ShellConstants.CSH, [{ executable: 'source', args: [path.join(binDir, `activate.csh`)] }]);
`178`	`178`	`shellDeactivation.set(ShellConstants.CSH, [{ executable: 'deactivate' }]);`
`179`		`-`
`180`		- shellActivation.set(ShellConstants.FISH, [{ executable: 'source', args: [path.join(binDir, `activate.csh`)] }]);
`181`		`- shellDeactivation.set(ShellConstants.FISH, [{ executable: 'deactivate' }]);`
`182`	`179`	`}`
`183`	`180`
`184`	`181`	`if (await fs.pathExists(path.join(binDir, 'activate.fish'))) {`