fix: address PR review comments

- Use monotonic counter instead of Date.now() in ShellExecution.computeId() for deterministic IDs
- Export UV_INSTALL_PYTHON_DONT_ASK_KEY constant and use in tests
- Capitalize 'Python' in noEnvFound localized string
- Re-check uv availability after installation to handle PATH issues
- Add uvInstallRestartRequired localized string for when uv is not on PATH

Author: karthiknadig

src/common/localize.ts

@@ -97,7 +97,7 @@ export namespace VenvManagerStrings {
     export const venvErrorNoPython3 = l10n.t('Did not find any base Python 3');
 
     export const noEnvClickToCreate = l10n.t('No environment found, click to create');
-    export const noEnvFound = l10n.t('No python environments found.');
+    export const noEnvFound = l10n.t('No Python environments found.');
     export const createEnvironment = l10n.t('Create Environment');
 
     export const venvName = l10n.t('Enter a name for the virtual environment');
@@ -228,8 +228,9 @@ export namespace UvInstallStrings {
         return l10n.t('Python installed successfully at {0}', path);
     }
     export const installFailed = l10n.t('Failed to install Python');
-    export const uvInstallFailed = l10n.t('Failed to install uv');
-    export const dontAskAgain = l10n.t("Don't ask again");
+    export const uvInstallFailed = l10n.t('Failed to install uv');    export const uvInstallRestartRequired = l10n.t(
+        'uv was installed but may not be available in the current terminal. Please restart VS Code or open a new terminal and try again.',
+    );    export const dontAskAgain = l10n.t("Don't ask again");
     export const clickToInstallPython = l10n.t('No Python found, click to install');
     export const selectPythonVersion = l10n.t('Select Python version to install');
     export const installed = l10n.t('installed');

src/managers/builtin/uvPythonInstaller.ts

@@ -20,7 +20,7 @@ import { isWindows } from '../../common/utils/platformUtils';
 import { showErrorMessage, showInformationMessage, showQuickPick, withProgress } from '../../common/window.apis';
 import { isUvInstalled, resetUvInstallationCache } from './helpers';
 
-const UV_INSTALL_PYTHON_DONT_ASK_KEY = 'python-envs:uv:UV_INSTALL_PYTHON_DONT_ASK';
+export const UV_INSTALL_PYTHON_DONT_ASK_KEY = 'python-envs:uv:UV_INSTALL_PYTHON_DONT_ASK';
 
 /**
  * Represents a Python version from uv python list
@@ -395,6 +395,15 @@ export async function installPythonWithUv(log?: LogOutputChannel, version?: stri
                     showErrorMessage(UvInstallStrings.uvInstallFailed);
                     return undefined;
                 }
+
+                // Verify uv is now available on PATH
+                const uvNowInstalled = await isUvInstalled(log);
+                if (!uvNowInstalled) {
+                    traceError('uv installed but not found on PATH - may require terminal restart');
+                    sendTelemetryEvent(EventNames.UV_PYTHON_INSTALL_FAILED, undefined, { stage: 'uvNotOnPath' });
+                    showErrorMessage(UvInstallStrings.uvInstallRestartRequired);
+                    return undefined;
+                }
             }
 
             // Step 2: Install Python via uv

src/test/managers/builtin/uvPythonInstaller.unit.test.ts

@@ -11,6 +11,7 @@ import {
     clearDontAskAgain,
     isDontAskAgainSet,
     promptInstallPythonViaUv,
+    UV_INSTALL_PYTHON_DONT_ASK_KEY,
 } from '../../../managers/builtin/uvPythonInstaller';
 import { createMockLogOutputChannel } from '../../mocks/helper';
 
@@ -91,7 +92,7 @@ suite('uvPythonInstaller - promptInstallPythonViaUv', () => {
         const result = await promptInstallPythonViaUv('activation', mockLog);
 
         assert.strictEqual(result, undefined);
-        assert(mockState.set.calledWith('python-envs:uv:UV_INSTALL_PYTHON_DONT_ASK', true), 'Should set dont ask flag');
+        assert(mockState.set.calledWith(UV_INSTALL_PYTHON_DONT_ASK_KEY, true), 'Should set dont ask flag');
     });
 
     test('should return undefined when user dismisses the dialog', async () => {
@@ -163,7 +164,7 @@ suite('uvPythonInstaller - isDontAskAgainSet and clearDontAskAgain', () => {
     test('clearDontAskAgain should set flag to false', async () => {
         await clearDontAskAgain();
 
-        assert(mockState.set.calledWith('python-envs:uv:UV_INSTALL_PYTHON_DONT_ASK', false), 'Should clear the flag');
+        assert(mockState.set.calledWith(UV_INSTALL_PYTHON_DONT_ASK_KEY, false), 'Should clear the flag');
     });
 });
 

src/test/mocks/vsc/extHostedTypes.ts

@@ -1613,6 +1613,8 @@ export class ProcessExecution implements vscode.ProcessExecution {
 }
 
 export class ShellExecution implements vscode.ShellExecution {
+    private static idCounter = 0;
+
     private _commandLine = '';
 
     private _command: string | vscode.ShellQuotedString = '';
@@ -1706,9 +1708,10 @@ export class ShellExecution implements vscode.ShellExecution {
         //     }
         // }
         // return hash.digest('hex');
-        // Return a simple unique ID based on command
+        // Return a deterministic unique ID based on command and a monotonic counter
         const cmd = typeof this._command === 'string' ? this._command : (this._command?.value ?? '');
-        return `shell-${cmd}-${Date.now()}`;
+        const argsStr = this._args?.map((a) => (typeof a === 'string' ? a : a.value)).join(',') ?? '';
+        return `shell-${cmd}-${argsStr}-${ShellExecution.idCounter++}`;
     }
 }