fix: reduce extension list for permissions check to installed extensions

Author: karthiknadig

src/common/extension.apis.ts

@@ -8,3 +8,14 @@ export function getExtension<T = any>(extensionId: string): Extension<T> | undef
 export function allExtensions(): readonly Extension<any>[] {
     return extensions.all;
 }
+
+export function allExternalExtensions(): readonly Extension<any>[] {
+    return allExtensions().filter((extension) => {
+        try {
+            return extension.packageJSON.publisher !== 'vscode';
+        } catch {
+            // No publisher
+            return false;
+        }
+    });
+}

src/features/permissions/packageManagerPermissions.ts

@@ -1,9 +1,9 @@
 import { l10n, SecretStorage } from 'vscode';
-import { pickExtension } from './pickers';
+import { pickExtensionForPermissions } from './pickers';
 import { showInformationMessage, showWarningMessage } from '../../common/window.apis';
 import { PermissionsCommon } from '../../common/localize';
 import { traceLog } from '../../common/logging';
-import { allExtensions } from '../../common/extension.apis';
+import { allExternalExtensions } from '../../common/extension.apis';
 import { getCallingExtension } from '../../common/utils/frameUtils';
 
 type PermissionType = 'Ask' | 'Allow' | 'Deny';
@@ -42,7 +42,7 @@ export class PackageManagerPermissionsImpl implements PackageManagerPermissions
     }
 
     async resetPermissions(): Promise<void> {
-        const ids = allExtensions().map((e) => `python-envs.permissions.packageManagement.${e.id}`);
+        const ids = allExternalExtensions().map((e) => `python-envs.permissions.packageManagement.${e.id}`);
         await Promise.all(ids.map((id) => this.secretStore.delete(id)));
         traceLog('All package management permissions have been reset.');
     }
@@ -180,7 +180,7 @@ export async function checkPackageManagementPermissions(
 }
 
 export async function handlePermissionsCommand(pm: PermissionsManager<PermissionType>, extensionId?: string) {
-    extensionId = extensionId ?? (await pickExtension());
+    extensionId = extensionId ?? (await pickExtensionForPermissions());
     if (!extensionId) {
         return;
     }

src/features/permissions/pickers.ts

@@ -1,5 +1,5 @@
 import { Extension, QuickPickItem } from 'vscode';
-import { allExtensions } from '../../common/extension.apis';
+import { allExternalExtensions } from '../../common/extension.apis';
 import { showQuickPick } from '../../common/window.apis';
 
 function getExtensionName(ext: Extension<unknown>): string {
@@ -11,7 +11,7 @@ function getExtensionName(ext: Extension<unknown>): string {
 }
 
 function getExtensionItems(): QuickPickItem[] {
-    const extensions = allExtensions();
+    const extensions = allExternalExtensions();
     return extensions.map((ext) => {
         return {
             description: ext.id,
@@ -20,7 +20,7 @@ function getExtensionItems(): QuickPickItem[] {
     });
 }
 
-export async function pickExtension(): Promise<string | undefined> {
+export async function pickExtensionForPermissions(): Promise<string | undefined> {
     const items = getExtensionItems();
 
     const result = await showQuickPick(items, {