fix: address Copilot review feedback (PR #1232)

- Fix Python 3.9 typing compatibility (use typing module)
- Remove unused imports: defaultdict in dependency_analysis.py
- Remove unused variables: func_start, since_date, agent_id
- Add explanatory comments for except pass blocks
- Fix uv pip install command in code-analysis.yml
- Update README.md to say Python 3.9+ instead of 3.10+
- Remove unused gitpython dependency from pyproject.toml
- Rename manager-discovery skill to python-manager-discovery
- Quote # symbol in cross-platform-paths description
- Set user-invocable: false for reference skills
- Remove / prefix from skill name references in agents/hooks

Author: karthiknadig

.github/agents/maintainer.agent.md

@@ -67,13 +67,13 @@ tools:
 
 Load these skills on-demand for detailed knowledge:
 
-| Skill                    | When to Use                                       |
-| ------------------------ | ------------------------------------------------- |
-| `/generate-snapshot`     | Generate codebase health snapshot for planning    |
-| `/run-pre-commit-checks` | Run mandatory checks before committing            |
-| `/cross-platform-paths`  | Reviewing/writing path-related code               |
-| `/settings-precedence`   | Reviewing/writing settings code                   |
-| `/manager-discovery`     | Working on specific manager (poetry, conda, etc.) |
+| Skill                      | When to Use                                       |
+| -------------------------- | ------------------------------------------------- |
+| `generate-snapshot`        | Generate codebase health snapshot for planning    |
+| `run-pre-commit-checks`    | Run mandatory checks before committing            |
+| `cross-platform-paths`     | Reviewing/writing path-related code               |
+| `settings-precedence`      | Reviewing/writing settings code                   |
+| `python-manager-discovery` | Working on specific manager (poetry, conda, etc.) |
 
 ---
 
@@ -103,7 +103,7 @@ Planning → Development → Review → Merge
 
 1. **Gather context:**
     - Check open GitHub issues (`github/list_issues`, `github/search_issues`)
-    - Generate snapshot: use `/generate-snapshot` skill for details
+    - Generate snapshot: Use `generate-snapshot` skill for details
     - Check open PRs for related work
 
 2. **Analyze and prioritize:**
@@ -140,9 +140,9 @@ git checkout -b feature/issue-N   # or bug/issue-N, chore/issue-N
 
 Follow guidelines from `.github/instructions/generic.instructions.md`:
 
-- **Paths:** Use `/cross-platform-paths` skill for patterns
-- **Settings:** Use `/settings-precedence` skill for patterns
-- **Managers:** Use `/manager-discovery` skill for manager-specific knowledge
+- **Paths:** Use `cross-platform-paths` skill for patterns
+- **Settings:** Use `settings-precedence` skill for patterns
+- **Managers:** Use `python-manager-discovery` skill for manager-specific knowledge
 - **Localization:** `l10n.t()` for user-facing messages
 - **Logging:** `traceLog`/`traceVerbose`, never `console.log`
 
@@ -172,7 +172,7 @@ Run **Reviewer** agent (`.github/agents/reviewer.agent.md`) with:
 
 ## 5. Pre-Commit Checks (REQUIRED)
 
-Use `/run-pre-commit-checks` skill for details. Quick reference:
+Use `run-pre-commit-checks` skill for details. Quick reference:
 
 ```powershell
 npm run lint           # ESLint

.github/agents/reviewer.agent.md

@@ -41,11 +41,11 @@ Automated reviews consistently miss:
 
 For deep-dive patterns, these skills provide additional context:
 
-| Skill                   | Use When                        |
-| ----------------------- | ------------------------------- |
-| `/cross-platform-paths` | Reviewing path-related code     |
-| `/settings-precedence`  | Reviewing settings code         |
-| `/manager-discovery`    | Reviewing manager-specific code |
+| Skill                      | Use When                        |
+| -------------------------- | ------------------------------- |
+| `cross-platform-paths`     | Reviewing path-related code     |
+| `settings-precedence`      | Reviewing settings code         |
+| `python-manager-discovery` | Reviewing manager-specific code |
 
 The patterns below are the essential subset needed during reviews.
 

.github/hooks/scripts/README.md

@@ -38,7 +38,7 @@ Runs when subagents complete:
 
 ## Requirements
 
-These scripts use Python 3.10+ with no external dependencies (beyond what's already in the repo).
+These scripts use Python 3.9+ with no external dependencies (beyond what's already in the repo).
 
 They expect:
 

.github/hooks/scripts/post_tool_use.py

@@ -13,6 +13,7 @@
 import subprocess
 import sys
 from pathlib import Path
+from typing import Dict, List, Optional
 
 # Tools that modify files and should trigger validation
 FILE_EDIT_TOOLS = {"editFiles", "createFile", "create_file", "replace_string_in_file"}
@@ -21,7 +22,7 @@
 TYPESCRIPT_EXTENSIONS = {".ts", ".tsx"}
 
 
-def run_eslint(files: list[str], cwd: Path) -> str | None:
+def run_eslint(files: List[str], cwd: Path) -> Optional[str]:
     """Run ESLint on specified files and return errors."""
     ts_files = [f for f in files if Path(f).suffix in TYPESCRIPT_EXTENSIONS]
     if not ts_files:
@@ -61,12 +62,14 @@ def run_eslint(files: list[str], cwd: Path) -> str | None:
 
                 return f"ESLint: {', '.join(summary)}. " + " | ".join(sample_errors[:3])
     except (subprocess.TimeoutExpired, FileNotFoundError):
+        # ESLint failures (timeout or missing binary) should not block the hook;
+        # treat them as "no lint results" and continue without reporting lint output.
         pass
 
     return None
 
 
-def extract_files_from_tool_input(tool_name: str, tool_input: dict) -> list[str]:
+def extract_files_from_tool_input(tool_name: str, tool_input: Dict) -> List[str]:
     """Extract file paths from tool input based on tool type."""
     files = []
 

.github/hooks/scripts/session_start.py

@@ -15,9 +15,10 @@
 import subprocess
 import sys
 from pathlib import Path
+from typing import Dict, List, Optional
 
 
-def run_command(cmd: list[str], cwd: Path | None = None) -> str | None:
+def run_command(cmd: List[str], cwd: Optional[Path] = None) -> Optional[str]:
     """Run a command and return stdout, or None on failure."""
     try:
         result = subprocess.run(
@@ -30,11 +31,12 @@ def run_command(cmd: list[str], cwd: Path | None = None) -> str | None:
         if result.returncode == 0:
             return result.stdout.strip()
     except (subprocess.TimeoutExpired, FileNotFoundError):
+        # Git/gh CLI not available or timed out; return None to skip this context.
         pass
     return None
 
 
-def get_git_context(repo_root: Path) -> dict:
+def get_git_context(repo_root: Path) -> Dict:
     """Get current git context."""
     context = {}
 
@@ -65,7 +67,7 @@ def get_git_context(repo_root: Path) -> dict:
     return context
 
 
-def get_issue_context(repo_root: Path) -> dict:
+def get_issue_context(repo_root: Path) -> Dict:
     """Get open issue context if gh CLI is available."""
     context = {}
 
@@ -97,7 +99,7 @@ def get_issue_context(repo_root: Path) -> dict:
     return context
 
 
-def get_snapshot_summary(repo_root: Path) -> dict:
+def get_snapshot_summary(repo_root: Path) -> Dict:
     """Get snapshot summary if available."""
     snapshot_path = repo_root / "analysis" / "analysis-snapshot.json"
     if not snapshot_path.exists():
@@ -115,6 +117,7 @@ def get_snapshot_summary(repo_root: Path) -> dict:
             "circular_dependencies": summary.get("circular_dependency_count", 0),
         }
     except (json.JSONDecodeError, OSError):
+        # Snapshot file unreadable or malformed; skip snapshot context.
         return {}
 
 
@@ -155,8 +158,8 @@ def main() -> int:
 
     # Add reminder about skills
     parts.append(
-        "Available skills: /generate-snapshot, /run-pre-commit-checks, "
-        "/cross-platform-paths, /settings-precedence, /manager-discovery"
+        "Available skills: generate-snapshot, run-pre-commit-checks, "
+        "cross-platform-paths, settings-precedence, python-manager-discovery"
     )
 
     # Output response

.github/hooks/scripts/stop_hook.py

@@ -13,9 +13,10 @@
 import subprocess
 import sys
 from pathlib import Path
+from typing import List, Optional, Tuple
 
 
-def run_command(cmd: list[str], cwd: Path | None = None) -> tuple[int, str]:
+def run_command(cmd: List[str], cwd: Optional[Path] = None) -> Tuple[int, str]:
     """Run a command and return (exit_code, output)."""
     try:
         result = subprocess.run(
@@ -96,7 +97,7 @@ def main() -> int:
                 "decision": "block",
                 "reason": (
                     "You have uncommitted TypeScript changes. "
-                    "Before finishing, run /run-pre-commit-checks skill "
+                    "Before finishing, use the run-pre-commit-checks skill "
                     "or manually run: npm run lint && npm run compile-tests && npm run unittest. "
                     "If checks pass and changes are ready, commit them. "
                     "If this session is just research/exploration, you can proceed without committing."

.github/hooks/scripts/subagent_stop.py

@@ -21,7 +21,7 @@ def main() -> int:
         input_data = {}
 
     agent_type = input_data.get("agent_type", "")
-    agent_id = input_data.get("agent_id", "")
+    # agent_id available in input_data if needed for logging
     stop_hook_active = input_data.get("stop_hook_active", False)
 
     # Prevent infinite loops

.github/skills/cross-platform-paths/SKILL.md

@@ -1,7 +1,8 @@
 ---
 name: cross-platform-paths
-description: Critical patterns for cross-platform path handling in this VS Code extension. Windows vs POSIX path bugs are the #1 source of issues. Use this skill when reviewing or writing path-related code.
+description: 'Critical patterns for cross-platform path handling in this VS Code extension. Windows vs POSIX path bugs are the #1 source of issues. Use this skill when reviewing or writing path-related code.'
 argument-hint: Review path handling in [file or component]
+user-invocable: false
 ---
 
 # Cross-Platform Path Handling

.github/skills/manager-discovery/SKILL.md …skills/python-manager-discovery/SKILL.md.github/skills/manager-discovery/SKILL.md renamed to .github/skills/python-manager-discovery/SKILL.md .github/skills/manager-discovery/SKILL.md renamed to .github/skills/python-manager-discovery/SKILL.md

@@ -1,8 +1,8 @@
 ---
-name: manager-discovery
+name: python-manager-discovery
 description: Environment manager-specific discovery patterns and known issues. Use when working on or reviewing environment discovery code for conda, poetry, pipenv, pyenv, or venv.
 argument-hint: 'manager name (e.g., poetry, conda, pyenv)'
-user-invocable: true
+user-invocable: false
 ---
 
 # Environment Manager Discovery Patterns

.github/skills/settings-precedence/SKILL.md

@@ -2,6 +2,7 @@
 name: settings-precedence
 description: VS Code settings precedence rules and common pitfalls. Essential for any code that reads or writes settings. Covers getConfiguration scope, inspect() vs get(), and multi-workspace handling.
 argument-hint: Review settings handling in [file or component]
+user-invocable: false
 ---
 
 # VS Code Settings Precedence