Skip to content

Commit c25f5d4

Browse files
committed
Use CLI flag --install-extensions instead of config property
The config property may be less reliable than the CLI flag for installing extensions before running tests.
1 parent de25df7 commit c25f5d4

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

.vscode-test.mjs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ export default defineConfig([
4141
`--user-data-dir=${userDataDir}`,
4242
'--disable-workspace-trust',
4343
],
44-
// Install ms-python.python for the native Python tools (pet binary).
45-
// We use inspect() for useEnvironmentsExtension check, so defaults are ignored.
46-
installExtensions: ['ms-python.python'],
44+
// ms-python.python is installed via CLI flag (--install-extensions) for
45+
// the native Python tools (pet binary). We use inspect() for
46+
// useEnvironmentsExtension check, so Python extension's default is ignored.
4747
},
4848
{
4949
label: 'integrationTests',
@@ -60,9 +60,9 @@ export default defineConfig([
6060
`--user-data-dir=${userDataDir}`,
6161
'--disable-workspace-trust',
6262
],
63-
// Install ms-python.python for the native Python tools (pet binary).
64-
// We use inspect() for useEnvironmentsExtension check, so defaults are ignored.
65-
installExtensions: ['ms-python.python'],
63+
// ms-python.python is installed via CLI flag (--install-extensions) for
64+
// the native Python tools (pet binary). We use inspect() for
65+
// useEnvironmentsExtension check, so Python extension's default is ignored.
6666
},
6767
{
6868
label: 'extensionTests',

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -683,8 +683,8 @@
683683
"lint": "eslint --config=eslint.config.mjs src",
684684
"unittest": "mocha --config=./build/.mocha.unittests.json",
685685
"smoke-test": "vscode-test --label smokeTests",
686-
"e2e-test": "vscode-test --label e2eTests",
687-
"integration-test": "vscode-test --label integrationTests",
686+
"e2e-test": "vscode-test --label e2eTests --install-extensions ms-python.python",
687+
"integration-test": "vscode-test --label integrationTests --install-extensions ms-python.python",
688688
"vsce-package": "vsce package -o ms-python-envs-insiders.vsix"
689689
},
690690
"devDependencies": {

0 commit comments

Comments
 (0)