Make sure to clean after shell startup changes when off

anthonykim1 · anthonykim1 · commit c9023accff7e · 2025-10-05T23:54:48.000-07:00
diff --git a/src/features/terminal/terminalManager.ts b/src/features/terminal/terminalManager.ts
@@ -129,7 +129,9 @@ export class TerminalManagerImpl implements TerminalManager {
                             await this.handleSetupCheck(shells);
                         }
                     } else {
-                        traceVerbose(`Auto activation type changed to ${actType}`);
+                        traceVerbose(`Auto activation type changed to ${actType}, we are cleaning up shell startup setup`);
+                         // Teardown scripts when switching away from shell startup activation
+                        await Promise.all(this.startupScriptProviders.map((p) => p.teardownScripts()));
                         this.shellSetup.clear();
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,9 @@ export class TerminalManagerImpl implements TerminalManager {`
`129`	`129`	`await this.handleSetupCheck(shells);`
`130`	`130`	`}`
`131`	`131`	`} else {`
`132`		- traceVerbose(`Auto activation type changed to ${actType}`);
	`132`	+ traceVerbose(`Auto activation type changed to ${actType}, we are cleaning up shell startup setup`);
	`133`	`+ // Teardown scripts when switching away from shell startup activation`
	`134`	`+ await Promise.all(this.startupScriptProviders.map((p) => p.teardownScripts()));`
`133`	`135`	`this.shellSetup.clear();`
`134`	`136`	`}`
`135`	`137`	`}`