Skip to content

Commit ddc501d

Browse files
committed
idk
1 parent 0f563ee commit ddc501d

File tree

4 files changed

+4
-157
lines changed

4 files changed

+4
-157
lines changed

src/test/e2e/environmentDiscovery.e2e.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import * as assert from 'assert';
2727
import * as vscode from 'vscode';
2828
import { ENVS_EXTENSION_ID } from '../constants';
29-
import { initializeTestSettings } from '../initialize';
3029
import { waitForCondition } from '../testUtils';
3130

3231
suite('E2E: Environment Discovery', function () {
@@ -40,10 +39,6 @@ suite('E2E: Environment Discovery', function () {
4039
};
4140

4241
suiteSetup(async function () {
43-
// CRITICAL: Configure settings BEFORE extension activation
44-
// This follows the vscode-python pattern of programmatic configuration
45-
await initializeTestSettings();
46-
4742
// Get and activate the extension
4843
const extension = vscode.extensions.getExtension(ENVS_EXTENSION_ID);
4944
assert.ok(extension, `Extension ${ENVS_EXTENSION_ID} not found`);

src/test/initialize.ts

Lines changed: 0 additions & 134 deletions
This file was deleted.

src/test/integration/envManagerApi.integration.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import * as assert from 'assert';
2424
import * as vscode from 'vscode';
2525
import { ENVS_EXTENSION_ID } from '../constants';
26-
import { initializeTestSettings } from '../initialize';
2726
import { TestEventHandler, waitForCondition } from '../testUtils';
2827

2928
suite('Integration: Environment Manager + API', function () {
@@ -41,10 +40,6 @@ suite('Integration: Environment Manager + API', function () {
4140
// Set a shorter timeout for setup specifically
4241
this.timeout(20_000);
4342

44-
// CRITICAL: Configure settings BEFORE extension activation
45-
// This follows the vscode-python pattern of programmatic configuration
46-
await initializeTestSettings();
47-
4843
const extension = vscode.extensions.getExtension(ENVS_EXTENSION_ID);
4944
assert.ok(extension, `Extension ${ENVS_EXTENSION_ID} not found`);
5045

src/test/smoke/activation.smoke.test.ts

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,30 +28,21 @@
2828
* - Retries once on failure (configured in the runner)
2929
* - Tests are independent - no shared state between tests
3030
*
31-
* CRITICAL PATTERN (from vscode-python):
32-
* Settings must be configured PROGRAMMATICALLY before extension activation.
33-
* Relying solely on settings.json files can fail because:
34-
* - The ms-python.python extension may set useEnvironmentsExtension=false by default
35-
* - Settings files may not be loaded before activation
36-
* - Race conditions between file I/O and extension initialization
31+
* NOTE: We do NOT install ms-python.python in test configuration.
32+
* This is intentional - that extension defines python.useEnvironmentsExtension=false
33+
* by default, which would cause our extension to skip activation.
34+
* Without it installed, our extension uses its own default of true.
3735
*/
3836

3937
import * as assert from 'assert';
4038
import * as vscode from 'vscode';
4139
import { ENVS_EXTENSION_ID, MAX_EXTENSION_ACTIVATION_TIME } from '../constants';
42-
import { initializeTestSettings } from '../initialize';
4340
import { waitForCondition } from '../testUtils';
4441

4542
suite('Smoke: Extension Activation', function () {
4643
// Smoke tests need longer timeouts - VS Code startup can be slow
4744
this.timeout(MAX_EXTENSION_ACTIVATION_TIME);
4845

49-
// CRITICAL: Configure settings BEFORE any test runs
50-
// This follows the vscode-python pattern of programmatic configuration
51-
suiteSetup(async function () {
52-
await initializeTestSettings();
53-
});
54-
5546
/**
5647
* Test: Extension is installed and VS Code can find it
5748
*

0 commit comments

Comments
 (0)