feat: add git-bash support

Author: karthiknadig

src/extension.ts

@@ -59,7 +59,8 @@ import { TerminalActivationImpl } from './features/terminal/terminalActivationSt
 import { getEnvironmentForTerminal } from './features/terminal/utils';
 import { PowershellStartupProvider } from './features/terminal/startup/powershellStartup';
 import { ShellStartupActivationManagerImpl } from './features/terminal/startup/activateUsingShellStartup';
-import { BashStartupProvider } from './features/terminal/startup/bashStartup';
+import { BashStartupProvider, GitBashStartupProvider } from './features/terminal/startup/bashStartup';
+import { isWindows } from './common/utils/platformUtils';
 
 export async function activate(context: ExtensionContext): Promise<PythonEnvironmentApi> {
     const start = new StopWatch();
@@ -86,7 +87,9 @@ export async function activate(context: ExtensionContext): Promise<PythonEnviron
     context.subscriptions.push(envManagers);
 
     const terminalActivation = new TerminalActivationImpl();
-    const shellStartupProviders = [new PowershellStartupProvider(), new BashStartupProvider()];
+    const shellStartupProviders = isWindows()
+        ? [new PowershellStartupProvider(), new GitBashStartupProvider()]
+        : [new PowershellStartupProvider(), new BashStartupProvider()];
     const shellStartupActivationManager = new ShellStartupActivationManagerImpl(
         context.environmentVariableCollection,
         shellStartupProviders,

src/features/terminal/startup/bashStartup.ts

@@ -211,3 +211,41 @@ export class BashStartupProvider implements ShellStartupProvider {
         }
     }
 }
+
+export class GitBashStartupProvider implements ShellStartupProvider {
+    async isSetup(): Promise<boolean> {
+        const bashProfiles = await getBashProfiles();
+        return await isStartupSetup(bashProfiles);
+    }
+    async setupScripts(): Promise<boolean> {
+        const bashProfiles = await getBashProfiles();
+        return await setupStartup(bashProfiles);
+    }
+    async teardownScripts(): Promise<boolean> {
+        const bashProfiles = await getBashProfiles();
+        return await removeBashStartup(bashProfiles);
+    }
+    async updateEnvVariables(envVars: EnvironmentVariableCollection, env: PythonEnvironment): Promise<void> {
+        const bashActivation = getActivationCommandForShell(env, TerminalShellType.gitbash);
+        if (bashActivation) {
+            const command = getCommandAsString(bashActivation);
+            envVars.replace(bashActivationEnvVarKey, command);
+        } else {
+            envVars.delete(bashActivationEnvVarKey);
+        }
+    }
+    async removeEnvVariables(envVars: EnvironmentVariableCollection): Promise<void> {
+        envVars.delete(bashActivationEnvVarKey);
+    }
+    async getEnvVariables(env?: PythonEnvironment): Promise<Map<string, string | undefined> | undefined> {
+        if (env) {
+            const bashActivation = getActivationCommandForShell(env, TerminalShellType.gitbash);
+            return bashActivation
+                ? new Map([[bashActivationEnvVarKey, getCommandAsString(bashActivation)]])
+                : undefined;
+        } else {
+            return new Map([[bashActivationEnvVarKey, undefined]]);
+        }
+    }
+    public readonly name: string = 'git-bash';
+}

src/features/terminal/startup/cmdStartup.ts

@@ -111,7 +111,7 @@ function getName(binPath: string): string {
 }
 
 function pathForGitBash(binPath: string): string {
-    return isWindows() ? binPath.replace(/\\/g, '/') : binPath;
+    return isWindows() ? binPath.replace(/\\/g, '/').replace(/^([a-zA-Z]):/, '/$1') : binPath;
 }
 
 async function getPythonInfo(env: NativeEnvInfo): Promise<PythonEnvironmentInfo> {