remove duplicate telemetry

Author: StellaHuang95

src/common/telemetry/constants.ts

@@ -74,14 +74,6 @@ export enum EventNames {
      * - reason: string ('tool_not_found')
      */
     MANAGER_REGISTRATION_SKIPPED = 'MANAGER_REGISTRATION.SKIPPED',
-    /**
-     * Telemetry event fired after manager registration when PET discovered environments
-     * of a kind whose corresponding manager did not register.
-     * Properties:
-     * - managerName: string (e.g. 'conda', 'pyenv', 'pipenv', 'poetry')
-     * - petEnvCount: number (how many envs PET found for that kind)
-     */
-    MANAGER_DISCOVERY_MISMATCH = 'MANAGER_DISCOVERY.MISMATCH',
 }
 
 // Map all events to their properties
@@ -310,15 +302,4 @@ export interface IEventNamePropertyMapping {
         managerName: string;
         reason: 'tool_not_found';
     };
-
-    /* __GDPR__
-        "manager_discovery.mismatch": {
-            "managerName": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "owner": "StellaHuang95" },
-            "petEnvCount": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true, "owner": "StellaHuang95" }
-        }
-    */
-    [EventNames.MANAGER_DISCOVERY_MISMATCH]: {
-        managerName: string;
-        petEnvCount: number;
-    };
 }

src/extension.ts

@@ -96,92 +96,13 @@ import { collectEnvironmentInfo, getEnvManagerAndPackageManagerConfigLevels, run
 import { EnvironmentManagers, ProjectCreators, PythonProjectManager } from './internal.api';
 import { registerSystemPythonFeatures } from './managers/builtin/main';
 import { SysPythonManager } from './managers/builtin/sysPythonManager';
-import {
-    createNativePythonFinder,
-    isNativeEnvInfo,
-    NativePythonEnvironmentKind,
-    NativePythonFinder,
-} from './managers/common/nativePythonFinder';
+import { createNativePythonFinder, NativePythonFinder } from './managers/common/nativePythonFinder';
 import { IDisposable } from './managers/common/types';
 import { registerCondaFeatures } from './managers/conda/main';
 import { registerPipenvFeatures } from './managers/pipenv/main';
 import { registerPoetryFeatures } from './managers/poetry/main';
 import { registerPyenvFeatures } from './managers/pyenv/main';
 
-/**
- * Map from PET NativePythonEnvironmentKind to the manager name used in registration.
- * Only includes kinds that have a dedicated manager (not system/venv/etc.).
- */
-const PET_KIND_TO_MANAGER: ReadonlyMap<NativePythonEnvironmentKind, string> = new Map([
-    [NativePythonEnvironmentKind.conda, 'conda'],
-    [NativePythonEnvironmentKind.pyenv, 'pyenv'],
-    [NativePythonEnvironmentKind.pyenvVirtualEnv, 'pyenv'],
-    [NativePythonEnvironmentKind.pipenv, 'pipenv'],
-    [NativePythonEnvironmentKind.poetry, 'poetry'],
-]);
-
-/**
- * Checks whether PET discovered environments whose corresponding manager did not register.
- * Uses a soft (cached) refresh so it doesn't trigger additional PET work.
- */
-async function checkPetManagerMismatch(
-    nativeFinder: NativePythonFinder,
-    envManagers: EnvironmentManagers,
-): Promise<void> {
-    const registeredIds = new Set(envManagers.managers.map((m) => m.id));
-
-    // Map manager names to their expected managerId prefix
-    const managerIdPrefixes: ReadonlyMap<string, string> = new Map([
-        ['conda', 'ms-python.python:conda'],
-        ['pyenv', 'ms-python.python:pyenv'],
-        ['pipenv', 'ms-python.python:pipenv'],
-        ['poetry', 'ms-python.python:poetry'],
-    ]);
-
-    // Use a single cached refresh to avoid triggering per-kind hard refreshes on cache miss
-    let allEnvs;
-    try {
-        allEnvs = await nativeFinder.refresh(false);
-    } catch {
-        // PET query failed — don't block post-init
-        return;
-    }
-
-    // Filter to only environment entries (not manager entries)
-    const envInfos = allEnvs.filter(isNativeEnvInfo);
-
-    // Group PET kinds by manager name to avoid double-counting (e.g. pyenv + pyenvVirtualEnv)
-    const kindsByManager = new Map<string, NativePythonEnvironmentKind[]>();
-    for (const [kind, managerName] of PET_KIND_TO_MANAGER) {
-        const existing = kindsByManager.get(managerName) ?? [];
-        existing.push(kind);
-        kindsByManager.set(managerName, existing);
-    }
-
-    for (const [managerName, kinds] of kindsByManager) {
-        const expectedPrefix = managerIdPrefixes.get(managerName);
-        if (!expectedPrefix) {
-            continue;
-        }
-
-        // Check if the corresponding manager registered
-        const isRegistered = Array.from(registeredIds).some((id) => id.startsWith(expectedPrefix));
-        if (isRegistered) {
-            continue;
-        }
-
-        // Manager not registered — count PET environments of any related kind
-        const totalPetEnvs = envInfos.filter((e) => e.kind !== undefined && kinds.includes(e.kind)).length;
-
-        if (totalPetEnvs > 0) {
-            sendTelemetryEvent(EventNames.MANAGER_DISCOVERY_MISMATCH, undefined, {
-                managerName,
-                petEnvCount: totalPetEnvs,
-            });
-        }
-    }
-}
-
 export async function activate(context: ExtensionContext): Promise<PythonEnvironmentApi | undefined> {
     // Only skip activation if user explicitly set useEnvironmentsExtension to false.
     // When disabled, the main Python extension handles environments instead (legacy mode).
@@ -673,9 +594,6 @@ export async function activate(context: ExtensionContext): Promise<PythonEnviron
 
                 // Log discovery summary to help users troubleshoot environment detection issues
                 await logDiscoverySummary(envManagers);
-
-                // Check for PET-vs-manager mismatches (PET found envs but manager didn't register)
-                await checkPetManagerMismatch(nativeFinder, envManagers);
             } catch (postInitError) {
                 traceError('Post-initialization tasks failed:', postInitError);
             }