Properly await promise in cleanupStartupScripts (#1156)

Tyriar · web-flow · commit f165623764f9 · 2026-02-03T09:18:00.000-08:00
diff --git a/src/features/terminal/shellStartupSetupHandlers.ts b/src/features/terminal/shellStartupSetupHandlers.ts
@@ -65,10 +65,10 @@ export async function handleSettingUpShellProfile(
 export async function cleanupStartupScripts(allProviders: ShellStartupScriptProvider[]): Promise<void> {
     await Promise.all(allProviders.map((provider) => provider.teardownScripts()));
     if (getAutoActivationType() === ACT_TYPE_SHELL) {
-        setAutoActivationType(ACT_TYPE_COMMAND);
         traceInfo(
             'Setting `python-envs.terminal.autoActivationType` to `command`, after removing shell startup scripts.',
         );
+        await setAutoActivationType(ACT_TYPE_COMMAND);
     }
     setImmediate(async () => await showInformationMessage(ActivationStrings.revertedShellStartupScripts));
 }

Original file line number	Diff line number	Diff line change
`@@ -65,10 +65,10 @@ export async function handleSettingUpShellProfile(`
`65`	`65`	`export async function cleanupStartupScripts(allProviders: ShellStartupScriptProvider[]): Promise<void> {`
`66`	`66`	`await Promise.all(allProviders.map((provider) => provider.teardownScripts()));`
`67`	`67`	`if (getAutoActivationType() === ACT_TYPE_SHELL) {`
`68`		`- setAutoActivationType(ACT_TYPE_COMMAND);`
`69`	`68`	`traceInfo(`
`70`	`69`	'Setting `python-envs.terminal.autoActivationType` to `command`, after removing shell startup scripts.',
`71`	`70`	`);`
	`71`	`+ await setAutoActivationType(ACT_TYPE_COMMAND);`
`72`	`72`	`}`
`73`	`73`	`setImmediate(async () => await showInformationMessage(ActivationStrings.revertedShellStartupScripts));`
`74`	`74`	`}`