Skip to content

Dont tear down shell startup when switched to command #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthonykim1 merged 2 commits into from
Dec 17, 2025
+1 −4
Merged

Dont tear down shell startup when switched to command #1071

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a7f468
Dont tear down shell startup when switched to command
anthonykim1 Dec 17, 2025
fb3bbc6
Don't touch this.shellSetup.clear()
anthonykim1 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/features/terminal/terminalManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,8 @@ export class TerminalManagerImpl implements TerminalManager {
}
} else {
traceVerbose(
`Auto activation type changed to ${actType}, we are cleaning up shell startup setup`,
`Auto activation type changed to ${actType}, not tearing down shell startup scripts on activation type switch; scripts are only removed via explicit revert.`,
);
// Teardown scripts when switching away from shell startup activation
await Promise.all(this.startupScriptProviders.map((p) => p.teardownScripts()));
this.shellSetup.clear();
}
}
Expand Down