Skip to content

Fix refresh failure caused by JSON-RPC sending [null] params to pet binary #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StellaHuang95 merged 1 commit into from
Apr 7, 2026
Merged

Fix refresh failure caused by JSON-RPC sending [null] params to pet binary #1442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/managers/common/nativePythonFinder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ class NativePythonFinderImpl implements NativePythonFinder {
this.connection.dispose();
}

private getRefreshOptions(options?: NativePythonEnvironmentKind | Uri[]): RefreshOptions | undefined {
private getRefreshOptions(options?: NativePythonEnvironmentKind | Uri[]): RefreshOptions {
// Note: venvFolders is also fetched in getAllExtraSearchPaths() for configure().
// This duplication is intentional: when searchPaths is provided to the native finder,
// it may override (not supplement) the configured environmentDirectories.
Expand All @@ -452,8 +452,8 @@ class NativePythonFinderImpl implements NativePythonFinder {
return { searchPaths: uriSearchPaths };
}
}
// return undefined to use configured defaults (for nativeFinder refresh)
return undefined;
// return empty object to use configured defaults (for nativeFinder refresh)
return {};
}

private start(): rpc.MessageConnection {
Expand Down
Loading