Conversation
| export const YES_INSTALL = 'Yes, Install'; | ||
| export const NO_INSTALL = 'Do Not Install'; | ||
|
|
||
| export function promptForInstallPermissions(extensionName: string, packages: string): Thenable<string | undefined> { |
There was a problem hiding this comment.
@karthiknadig what is the best way to handle all the string literals between the prompts and the decision cases? Is constants the right way?
There was a problem hiding this comment.
These should be put in localize.ts
There was a problem hiding this comment.
sounds good, I will move them over once we determine what they should say
| "preview" | ||
| ] | ||
| }, | ||
| "python-envs.extensionPackageTrust": { |
There was a problem hiding this comment.
This is not really trust, it is more of automatic package management. So this should likely say, allowAutoPackageManagement
/cc @cwebster-99 @luabud
There was a problem hiding this comment.
switched it to this for now but very flexible on this name - don't have a strong preference at the moment
| export const YES_INSTALL = 'Yes, Install'; | ||
| export const NO_INSTALL = 'Do Not Install'; | ||
|
|
||
| export function promptForInstallPermissions(extensionName: string, packages: string): Thenable<string | undefined> { |
There was a problem hiding this comment.
These should be put in localize.ts
| return new Promise((resolve) => { | ||
| window | ||
| .showInformationMessage( | ||
| 'Do you want to install the following package/s from the ' + extensionName + ' extension?', |
There was a problem hiding this comment.
Will we be referencing the package names in this message as well?
There was a problem hiding this comment.
Yes, but if there are multiple then we may want to say something like pandas, … or “pandas and other packages”.
There was a problem hiding this comment.
I added it in the detail: package/s: "${packages}", section. Is this what you mean? What is the best way to word it?
There was a problem hiding this comment.
Oh I see! I missed that part in the initial review
cwebster-99
left a comment
cwebster-99
left a comment
There was a problem hiding this comment.
Left some comments but the options may be too verbose for the UI they are shown in. If that is the case, we can iterate.
Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com>
| "alwaysAsk" | ||
| ], | ||
| "default": "alwaysAsk", | ||
| "description": "Sets how installs by a given extension will be handled from the environment extension." |
There was a problem hiding this comment.
| "description": "Sets how installs by a given extension will be handled from the environment extension." | |
| "description": "Configures package installation permissions for a given extension." |
4 participants
fixes #136