Skip to content

Adding menu items#310

Merged
eleanorjboyd merged 5 commits intomicrosoft:create-project-branchfrom
eleanorjboyd:adding-menu-items
Apr 16, 2025
Merged

Adding menu items#310
eleanorjboyd merged 5 commits intomicrosoft:create-project-branchfrom
eleanorjboyd:adding-menu-items

Conversation

@eleanorjboyd
Copy link
Copy Markdown
Member

No description provided.

@eleanorjboyd
Copy link
Copy Markdown
Member Author

Screenshot 2025-04-15 at 11 49 36 AM Screenshot 2025-04-15 at 11 50 11 AM

Copy link
Copy Markdown
Member

@cwebster-99 cwebster-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial wording feedback

Comment thread src/features/creators/newPackageProject.ts Outdated
Comment thread src/features/creators/newPackageProject.ts Outdated
Comment thread src/features/creators/newPackageProject.ts Outdated
Comment thread src/features/creators/newPackageProject.ts Outdated
Comment thread src/features/creators/newScriptProject.ts Outdated
public readonly name = 'newScript';
public readonly displayName = 'Script';
public readonly description = 'Create a new Python script project';
public readonly tooltip = new MarkdownString('Create a new Python script with basic structure');
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here, should we be presenting this as the base "Python project"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so do you think I should just say "project" for the display name then too? Once we get pep 723 then we will look to separate them since the requirements will be done differently?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also do we care these are the same wording:

public readonly description = 'Create a new Python project';
public readonly tooltip = new MarkdownString('Create a new Python project');

Comment thread src/features/creators/newScriptProject.ts Outdated
Comment thread src/common/pickers/managers.ts Outdated
Comment thread src/common/pickers/managers.ts Outdated
@eleanorjboyd eleanorjboyd changed the base branch from main to create-project-branch April 16, 2025 19:55
@eleanorjboyd eleanorjboyd marked this pull request as ready for review April 16, 2025 19:55
@eleanorjboyd eleanorjboyd merged commit f325412 into microsoft:create-project-branch Apr 16, 2025
6 checks passed
eleanorjboyd added a commit that referenced this pull request Apr 22, 2025
eleanorjboyd added a commit to eleanorjboyd/vscode-python-environments that referenced this pull request Apr 24, 2025
eleanorjboyd added a commit that referenced this pull request Apr 24, 2025
eleanorjboyd added a commit to eleanorjboyd/vscode-python-environments that referenced this pull request Apr 25, 2025
eleanorjboyd added a commit to eleanorjboyd/vscode-python-environments that referenced this pull request Apr 25, 2025
eleanorjboyd added a commit that referenced this pull request May 13, 2025
eleanorjboyd added a commit to eleanorjboyd/vscode-python-environments that referenced this pull request May 13, 2025
eleanorjboyd added a commit to eleanorjboyd/vscode-python-environments that referenced this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants