Fix PyEnv section endlessly spinning when pyenv is not installed#438
Closed
Fix PyEnv section endlessly spinning when pyenv is not installed#438
Conversation
Copilot
AI
changed the title
[WIP] PyEnv endlessly spins
Fix PyEnv section endlessly spinning when pyenv is not installed
May 20, 2025
karthiknadig
previously requested changes
May 21, 2025
Member
karthiknadig
left a comment
There was a problem hiding this comment.
registerEnvironmentManager should not be called if pyenv is not found on the machine.
Contributor
Author
I've updated the code to ensure |
bpasero
approved these changes
May 21, 2025
benibenj
approved these changes
May 21, 2025
Co-authored-by: karthiknadig <3840081+karthiknadig@users.noreply.github.com>
Co-authored-by: karthiknadig <3840081+karthiknadig@users.noreply.github.com>
fc8f621 to
919b7be
Compare
auto-merge was automatically disabled
May 21, 2025 15:37
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When pyenv is not installed on a user's machine, the PyEnv section in the Python Environments view shows an infinite loading spinner when expanded:
Root Cause
In the
refreshPyenvfunction, when pyenv is not found initially, the code tries to get it from the NativePythonFinder data. However, it doesn't check if any pyenv managers were found before trying to accessmanagers[0].executable:This causes an error when pyenv is not installed, leaving the UI in an infinite loading state.
Fix
Added a check to ensure the managers array has elements before trying to access the first one:
This ensures the UI doesn't get stuck in a loading state when pyenv is not installed on the system.
Fixes #437.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.