Skip to content

add quoting logic in runAsTask #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eleanorjboyd merged 5 commits into from
Jul 28, 2025
Merged

add quoting logic in runAsTask #651

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf283f0
add quoting logic in runAsTask
eleanorjboyd Jul 25, 2025
1c15d37
use quoteArg
eleanorjboyd Jul 25, 2025
d1f642e
Merge branch 'main' into quote-executable-task
eleanorjboyd Jul 25, 2025
fd32610
forgot to set return value
eleanorjboyd Jul 25, 2025
8b85d0b
Merge branch 'main' into quote-executable-task
eleanorjboyd Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/features/execution/execUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
function quoteArg(arg: string): string {
export function quoteArg(arg: string): string {
if (arg.indexOf(' ') >= 0 && !(arg.startsWith('"') && arg.endsWith('"'))) {
return `"${arg}"`;
}
Expand Down
10 changes: 5 additions & 5 deletions src/features/execution/runAsTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import {
Uri,
WorkspaceFolder,
} from 'vscode';
import { PythonTaskExecutionOptions } from '../../api';
import { getWorkspaceFolder } from '../../common/workspace.apis';
import { PythonEnvironment } from '../../api';
import { PythonEnvironment, PythonTaskExecutionOptions } from '../../api';
import { executeTask } from '../../common/tasks.apis';
import { getWorkspaceFolder } from '../../common/workspace.apis';
import { quoteArg } from './execUtils';

function getWorkspaceFolderOrDefault(uri?: Uri): WorkspaceFolder | TaskScope {
const workspace = uri ? getWorkspaceFolder(uri) : undefined;
Expand All @@ -25,8 +25,8 @@ export async function runAsTask(
): Promise<TaskExecution> {
const workspace: WorkspaceFolder | TaskScope = getWorkspaceFolderOrDefault(options.project?.uri);

const executable =
environment.execInfo?.activatedRun?.executable ?? environment.execInfo?.run.executable ?? 'python';
let executable = environment.execInfo?.activatedRun?.executable ?? environment.execInfo?.run.executable ?? 'python';
quoteArg(executable);
const args = environment.execInfo?.activatedRun?.args ?? environment.execInfo?.run.args ?? [];
const allArgs = [...args, ...options.args];

Expand Down