Skip to content

Bug in create venv flow with selecting skipping package installation #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eleanorjboyd merged 3 commits into from
Oct 10, 2025
Merged

Bug in create venv flow with selecting skipping package installation #928

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a3ef8a
Bug in create venv flow with selecting skipping package installation
eleanorjboyd Oct 10, 2025
5edfeb7
Merge branch 'main' into frightened-marten
eleanorjboyd Oct 10, 2025
b6d1501
Update src/managers/builtin/pipUtils.ts
eleanorjboyd Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/managers/builtin/pipUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ async function selectWorkspaceOrCommon(
return await selectFromCommonPackagesToInstall(common, installed, undefined, { showBackButton });
} else if (selected.label === PackageManagement.skipPackageInstallation) {
traceInfo('Package Installer: user selected skip package installation');
return undefined;
return { install: [], uninstall: [] } as PipPackages;
Comment thread
eleanorjboyd marked this conversation as resolved.
Outdated
} else {
return undefined;
}
Expand Down
Loading