Skip to content

Commit 0bafffd

Browse files
IanMatthewHuffIan Huff
andauthored
pass cancellation token so install actually waits to finish (#240)
Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local>
1 parent 7dbcd79 commit 0bafffd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/client/common/installer/productInstaller.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export class DataScienceInstaller extends BaseInstaller {
115115
public async install(
116116
product: Product,
117117
interpreterUri?: InterpreterUri,
118-
_cancel?: CancellationToken
118+
cancel?: CancellationToken
119119
): Promise<InstallerResponse> {
120120
// Precondition
121121
if (isResource(interpreterUri)) {
@@ -125,7 +125,7 @@ export class DataScienceInstaller extends BaseInstaller {
125125

126126
// At this point we know that `interpreterUri` is of type PythonInterpreter
127127
const interpreter = interpreterUri as PythonEnvironment;
128-
const result = await installer.install(product, interpreter);
128+
const result = await installer.install(product, interpreter, cancel);
129129

130130
if (result === InstallerResponse.Disabled || result === InstallerResponse.Ignore) {
131131
return result;

0 commit comments

Comments
 (0)