eslint

Author: ericsnowcurrently

.eslintignore

@@ -135,7 +135,6 @@ src/test/testing/navigation/suiteNavigator.unit.test.ts
 src/test/testing/navigation/commandHandlers.unit.test.ts
 src/test/testing/navigation/helper.unit.test.ts
 src/test/testing/navigation/symbolNavigator.unit.test.ts
-src/test/testing/configuration.unit.test.ts
 src/test/testing/explorer/treeView.unit.test.ts
 src/test/testing/explorer/testExplorerCommandHandler.unit.test.ts
 src/test/testing/explorer/failedTestHandler.unit.test.ts

src/client/testing/configuration/index.ts

@@ -19,6 +19,8 @@ import {
     UnitTestProduct,
 } from '../common/types';
 
+export const NONE_SELECTED = Error('none selected');
+
 @injectable()
 export class UnitTestConfigurationService implements ITestConfigurationService {
     private readonly configurationService: IConfigurationService;
@@ -51,7 +53,7 @@ export class UnitTestConfigurationService implements ITestConfigurationService {
             option,
         );
         if (item !== option) {
-            throw Error();
+            throw NONE_SELECTED;
         }
         return this._promptToEnableAndConfigureTestFramework(wkspace);
     }
@@ -127,7 +129,7 @@ export class UnitTestConfigurationService implements ITestConfigurationService {
         try {
             const selectedTestRunner = await this.selectTestRunner(messageToDisplay);
             if (typeof selectedTestRunner !== 'number') {
-                throw Error();
+                throw NONE_SELECTED;
             }
             const helper = this.serviceContainer.get<ITestsHelper>(ITestsHelper);
             telemetryProps.tool = helper.parseProviderName(selectedTestRunner);

src/test/testing/configuration.unit.test.ts

@@ -21,7 +21,7 @@ import {
 } from '../../client/testing/common/types';
 import { TEST_OUTPUT_CHANNEL } from '../../client/testing/constants';
 import { ITestingSettings } from '../../client/testing/configuration/types';
-import { UnitTestConfigurationService } from '../../client/testing/configuration';
+import { NONE_SELECTED, UnitTestConfigurationService } from '../../client/testing/configuration';
 
 suite('Unit Tests - ConfigurationService', () => {
     UNIT_TEST_PRODUCTS.forEach((product) => {
@@ -263,7 +263,7 @@ suite('Unit Tests - ConfigurationService', () => {
                 try {
                     await testConfigService.target.displayTestFrameworkError(workspaceUri);
                 } catch (exc) {
-                    if (exc !== null) {
+                    if (exc !== NONE_SELECTED) {
                         throw exc;
                     }
                     exceptionThrown = true;
@@ -294,7 +294,7 @@ suite('Unit Tests - ConfigurationService', () => {
                         });
                     await testConfigService.target.displayTestFrameworkError(workspaceUri);
                 } catch (exc) {
-                    if (exc !== null) {
+                    if (exc !== NONE_SELECTED) {
                         throw exc;
                     }
                     exceptionThrown = true;
@@ -333,7 +333,7 @@ suite('Unit Tests - ConfigurationService', () => {
                     .setup((t) => t.selectTestRunner(typeMoq.It.isAny()))
                     .returns(() => {
                         selectTestRunnerInvoked = true;
-                        return Promise.resolve(product as any);
+                        return Promise.resolve(product);
                     });
 
                 const configMgr = typeMoq.Mock.ofType<ITestConfigurationManager>(
@@ -382,7 +382,7 @@ suite('Unit Tests - ConfigurationService', () => {
                 try {
                     await testConfigService.target.displayTestFrameworkError(workspaceUri);
                 } catch (exc) {
-                    if (exc !== null) {
+                    if (exc !== NONE_SELECTED) {
                         throw exc;
                     }
                     exceptionThrown = true;
@@ -407,7 +407,7 @@ suite('Unit Tests - ConfigurationService', () => {
                     .setup((t) => t.selectTestRunner(typeMoq.It.isAny()))
                     .returns(() => {
                         selectTestRunnerInvoked = true;
-                        return Promise.resolve(product as any);
+                        return Promise.resolve(product);
                     });
 
                 let enableTestInvoked = false;
@@ -475,7 +475,7 @@ suite('Unit Tests - ConfigurationService', () => {
                     .setup((t) => t.selectTestRunner(typeMoq.It.isAny()))
                     .returns(() => {
                         selectTestRunnerInvoked = true;
-                        return Promise.resolve(product as any);
+                        return Promise.resolve(product);
                     });
 
                 const configMgr = typeMoq.Mock.ofType<ITestConfigurationManager>();