Skip to content

Commit d747391

Browse files
committed
more todo
1 parent 96d8f8f commit d747391

File tree

1 file changed

+2
-2
lines changed
  • src/client/terminals/envCollectionActivation

1 file changed

+2
-2
lines changed

src/client/terminals/envCollectionActivation/service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,8 +380,7 @@ export class TerminalEnvVarCollectionService implements IExtensionActivationServ
380380
return;
381381
}
382382

383-
// For virtual environments, get the bin directory
384-
// TODO: Make sure we test+get it working for conda, etc as well.
383+
// TODO, important: Make sure we test+get it working for conda, etc as well.
385384
if (interpreter.envType !== EnvironmentType.Venv && interpreter.type !== PythonEnvType.Virtual) {
386385
envVarCollection.clear();
387386
return;
@@ -427,6 +426,7 @@ export class TerminalEnvVarCollectionService implements IExtensionActivationServ
427426
}
428427

429428
// Command Prompt
429+
// TODO: We need to modify user's shell init for cmd, shell integration doesnt work for cmd
430430
const cmdActivate = path.join(binDir, 'activate.bat');
431431
if (await pathExists(cmdActivate)) {
432432
traceLog(`Setting VSCODE_PYTHON_CMD_ACTIVATE to ${cmdActivate}`);

0 commit comments

Comments
 (0)