Skip to content

Commit e2681d5

Browse files
bump Node.js version to 22.21.1 across multiple configuration files (#25612)
Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
1 parent eb6df9a commit e2681d5

File tree

9 files changed

+29
-26
lines changed

9 files changed

+29
-26
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM mcr.microsoft.com/devcontainers/typescript-node:18-bookworm
1+
FROM mcr.microsoft.com/devcontainers/typescript-node:22-bookworm
22

33
RUN apt-get install -y wget bzip2
44

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111
permissions: {}
1212

1313
env:
14-
NODE_VERSION: 22.17.0
14+
NODE_VERSION: 22.21.1
1515
PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
1616
# Force a path with spaces and to test extension works in these scenarios
1717
# Unicode characters are causing 2.7 failures so skip that for now.

.github/workflows/pr-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
permissions: {}
1111

1212
env:
13-
NODE_VERSION: 22.17.0
13+
NODE_VERSION: 22.21.1
1414
PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
1515
MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it haven't already.
1616
ARTIFACT_NAME_VSIX: ms-python-insiders-vsix

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v20.18.0
1+
v22.21.1

build/azure-pipelines/pipeline.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ extends:
3737
testPlatforms:
3838
- name: Linux
3939
nodeVersions:
40-
- 22.17.0
40+
- 22.21.1
4141
- name: MacOS
4242
nodeVersions:
43-
- 22.17.0
43+
- 22.21.1
4444
- name: Windows
4545
nodeVersions:
46-
- 22.17.0
46+
- 22.21.1
4747
testSteps:
4848
- template: /build/azure-pipelines/templates/test-steps.yml@self
4949
parameters:

package-lock.json

Lines changed: 18 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1746,7 +1746,7 @@
17461746
"@types/glob": "^7.2.0",
17471747
"@types/lodash": "^4.14.104",
17481748
"@types/mocha": "^9.1.0",
1749-
"@types/node": "^22.5.0",
1749+
"@types/node": "^22.19.1",
17501750
"@types/semver": "^5.5.0",
17511751
"@types/shortid": "^0.0.29",
17521752
"@types/sinon": "^17.0.3",

pythonExtensionApi/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"main": "./out/main.js",
1414
"types": "./out/main.d.ts",
1515
"engines": {
16-
"node": ">=22.17.0",
16+
"node": ">=22.21.1",
1717
"vscode": "^1.93.0"
1818
},
1919
"license": "MIT",

src/client/common/process/rawProcessApis.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ export function shellExec(
5858
const shellOptions = getDefaultOptions(options, defaultEnv);
5959
if (!options.doNotLog) {
6060
const processLogger = new ProcessLogger(new WorkspaceService());
61-
processLogger.logProcess(command, undefined, shellOptions);
61+
const loggingOptions = { ...shellOptions, encoding: shellOptions.encoding ?? undefined };
62+
processLogger.logProcess(command, undefined, loggingOptions);
6263
}
6364
return new Promise((resolve, reject) => {
6465
// eslint-disable-next-line @typescript-eslint/no-explicit-any

0 commit comments

Comments
 (0)