Skip to content

Move coverage to nightly and simplify reporting#15776

Merged
karthiknadig merged 13 commits intomicrosoft:mainfrom
karthiknadig:coverage2
Mar 26, 2021
Merged

Move coverage to nightly and simplify reporting#15776
karthiknadig merged 13 commits intomicrosoft:mainfrom
karthiknadig:coverage2

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

No description provided.

@karthiknadig karthiknadig changed the title Enable coverage for venv and single workspace tests Move coverage to nightly and simplify reporting Mar 25, 2021
@karthiknadig karthiknadig added the no-changelog No news entry required label Mar 25, 2021
@karthiknadig karthiknadig marked this pull request as ready for review March 25, 2021 21:01
@github-actions github-actions bot requested a review from paulacamargo25 March 25, 2021 21:02
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 25, 2021

Codecov Report

Merging #15776 (865d154) into main (23b6f3d) will decrease coverage by 47%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           main   #15776    +/-   ##
======================================
- Coverage    47%       0%   -48%     
======================================
  Files        11        7     -4     
  Lines       427       14   -413     
  Branches     60        1    -59     
======================================
- Hits        201        0   -201     
+ Misses      214       14   -200     
+ Partials     12        0    -12     
Impacted Files Coverage Δ
...or/esm/vs/platform/contextkey/common/contextkey.js
node_modules/webpack/buildin/global.js
...es/vscode-languageclient/lib/common/utils/async.js
...aco-editor/esm/vs/platform/editor/common/editor.js
..._modules/monaco-editor/esm/vs/base/common/types.js
...lient/common/process/internal/scripts/constants.ts 0% <0%> (ø)

@karthiknadig karthiknadig added the skip package*.json package.json and package-lock.json don't both need updating label Mar 25, 2021
@karthiknadig
Copy link
Copy Markdown
Member Author

Not sure why codecov reports 0% when NYC shows 70%:
https://github.com/microsoft/vscode-python/pull/15776/checks?check_run_id=2196975663

Copy link
Copy Markdown
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments from other folks to address as well.

@karthiknadig karthiknadig merged commit 9b881fc into microsoft:main Mar 26, 2021
file: ${{env.special-working-directory}}/coverage/cobertura-coverage.xml

upload:
name: Upload VSIX to Azure Blob Storage
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthiknadig Looks like we accidently removed this step. Development build is no longer updated.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0%. Comparing base (23b6f3d) to head (65bcc47).
⚠️ Report is 2391 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##           main   #15776    +/-   ##
======================================
- Coverage    47%       0%   -48%     
======================================
  Files        11        7     -4     
  Lines       427       14   -413     
  Branches     60        1    -59     
======================================
- Hits        201        0   -201     
+ Misses      214       14   -200     
+ Partials     12        0    -12     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants