Fix handling of test results with undefined status.#15348
Closed
ericsnowcurrently wants to merge 4 commits intomicrosoft:mainfrom
Closed
Fix handling of test results with undefined status.#15348ericsnowcurrently wants to merge 4 commits intomicrosoft:mainfrom
undefined status.#15348ericsnowcurrently wants to merge 4 commits intomicrosoft:mainfrom
Conversation
ericsnowcurrently
force-pushed
the
testing-results-undefined-status
branch
from
8f8da4d to
8015cf5
Compare
Codecov Report
@@ Coverage Diff @@
## main #15348 +/- ##
======================================
- Coverage 65% 65% -1%
======================================
Files 559 559
Lines 26799 26804 +5
Branches 3868 3869 +1
======================================
Hits 17447 17447
- Misses 8634 8639 +5
Partials 718 718
|
kimadeline
reviewed
Feb 10, 2021
| private getDiagnosticMessage(message: IPythonTestFailMessage): string { | ||
| const diagPrefix = this.unitTestDiagnosticService.getMessagePrefix(message.status)!; | ||
| const diagMsg = message.message ? message.message.split('\n')[0] : ''; | ||
| return `${diagPrefix}: ${diagMsg}`; |
There was a problem hiding this comment.
Will this change have no impact on the issue that caused us to introduce the "Ok" string in the diagnostic message? #14067
| } | ||
| export interface IPythonTestFailMessage extends IPythonTestMessageCommon { | ||
| status: Exclude<TestStatus, TestStatus.Pass>; | ||
| severity: PythonTestMessageSeverity.Error | PythonTestMessageSeverity.Skip; |
There was a problem hiding this comment.
Why aren't we handling PythonTestMessageSeverity.Failure?
Author
There was a problem hiding this comment.
Good catch. I'll fix that (properly).
Author
|
There's a bunch of cleanup involved to do this right, which obscures the key change here. I'm going to put up 2 PRs to keep things separate. (#15387 and ???) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(fixes #14866)
The 2 key changes are:
TestMessageService.getFilteredTestMessages(), skip test results with anundefinedstatusNote: I will be updating for eslint once reviews are done.