add support for implicit requests in chat service and view model

Author: meganrogge

src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts

@@ -832,7 +832,7 @@ export class ChatListItemRenderer extends Disposable implements ITreeRenderer<Ch
 		templateData.rowContainer.classList.toggle('confirmation-message', isRequestVM(element) && !!element.confirmation);
 
 		// TODO: @justschen decide if we want to hide the header for requests or not
-		const shouldShowHeader = isResponseVM(element) && !this.rendererOptions.noHeader;
+		const shouldShowHeader = (isResponseVM(element) && !this.rendererOptions.noHeader) || false;
 		templateData.header?.classList.toggle('header-disabled', !shouldShowHeader);
 
 		if (isRequestVM(element) && element.confirmation) {

src/vs/workbench/contrib/chat/common/chatService/chatService.ts

@@ -1407,6 +1407,14 @@ export interface IChatSendRequestOptions {
 	 */
 	pauseQueue?: boolean;
 
+	/**
+	 * When true, the request is rendered as a compact tool-progress-style line
+	 * instead of a full user message bubble. Used for system-initiated notifications
+	 * such as terminal command completion.
+	 */
+	isImplicit?: boolean;
+
+
 }
 
 export type IChatModelReference = IReference<IChatModel>;

src/vs/workbench/contrib/chat/common/chatService/chatServiceImpl.ts

@@ -861,6 +861,7 @@ export class ChatService extends Disposable implements IChatService {
 			attachedContext: options.attachedContext,
 			modelId: options.userSelectedModelId,
 			userSelectedTools: options.userSelectedTools?.get(),
+			isImplicit: options.isImplicit,
 		});
 
 		const deferred = new DeferredPromise<ChatSendResult>();
@@ -1163,7 +1164,7 @@ export class ChatService extends Disposable implements IChatService {
 				if (agentPart || (defaultAgent && !commandPart)) {
 					const prepareChatAgentRequest = (agent: IChatAgentData, command?: IChatAgentCommand, enableCommandDetection?: boolean, chatRequest?: ChatRequestModel, isParticipantDetected?: boolean): IChatAgentRequest => {
 						const initVariableData: IChatRequestVariableData = { variables: [] };
-						request = chatRequest ?? model.addRequest(parsedRequest, initVariableData, attempt, options?.modeInfo, agent, command, options?.confirmation, options?.locationData, options?.attachedContext, undefined, options?.userSelectedModelId, options?.userSelectedTools?.get());
+						request = chatRequest ?? model.addRequest(parsedRequest, initVariableData, attempt, options?.modeInfo, agent, command, options?.confirmation, options?.locationData, options?.attachedContext, undefined, options?.userSelectedModelId, options?.userSelectedTools?.get(), undefined, options?.isImplicit);
 
 						let variableData: IChatRequestVariableData;
 						let message: string;

src/vs/workbench/contrib/chat/common/model/chatModel.ts

@@ -126,6 +126,7 @@ export interface IChatRequestModel {
 	setShouldBeBlocked(value: boolean): void;
 	readonly modelId?: string;
 	readonly userSelectedTools?: UserSelectedTools;
+	readonly isImplicit?: boolean;
 }
 
 export interface ICodeBlockInfo {
@@ -342,6 +343,7 @@ export interface IChatRequestModelParameters {
 	restoredId?: string;
 	editedFileEvents?: IChatAgentEditedFileEvent[];
 	userSelectedTools?: UserSelectedTools;
+	isImplicit?: boolean;
 }
 
 export class ChatRequestModel implements IChatRequestModel {
@@ -354,6 +356,7 @@ export class ChatRequestModel implements IChatRequestModel {
 	public readonly modelId?: string;
 	public readonly modeInfo?: IChatRequestModeInfo;
 	public readonly userSelectedTools?: UserSelectedTools;
+	public readonly isImplicit?: boolean;
 
 	private readonly _shouldBeBlocked = observableValue<boolean>(this, false);
 	public get shouldBeBlocked(): IObservable<boolean> {
@@ -425,6 +428,7 @@ export class ChatRequestModel implements IChatRequestModel {
 		this.id = params.restoredId ?? 'request_' + generateUuid();
 		this._editedFileEvents = params.editedFileEvents;
 		this.userSelectedTools = params.userSelectedTools;
+		this.isImplicit = params.isImplicit;
 	}
 
 	adoptTo(session: ChatModel) {
@@ -1510,6 +1514,7 @@ export interface ISerializableChatRequestData extends ISerializableChatResponseD
 	editedFileEvents?: IChatAgentEditedFileEvent[];
 	modelId?: string;
 	modeInfo?: IChatRequestModeInfo;
+	isImplicit?: boolean;
 }
 
 export interface ISerializableMarkdownInfo {
@@ -2375,6 +2380,7 @@ export class ChatModel extends Disposable implements IChatModel {
 			editedFileEvents: raw.editedFileEvents,
 			modelId: raw.modelId,
 			modeInfo: raw.modeInfo,
+			isImplicit: raw.isImplicit,
 		});
 		request.shouldBeRemovedOnSend = raw.isHidden ? { requestId: raw.requestId } : raw.shouldBeRemovedOnSend;
 		// eslint-disable-next-line @typescript-eslint/no-explicit-any, local/code-no-any-casts
@@ -2543,7 +2549,7 @@ export class ChatModel extends Disposable implements IChatModel {
 		this._onDidChange.fire({ kind: 'setHidden' });
 	}
 
-	addRequest(message: IParsedChatRequest, variableData: IChatRequestVariableData, attempt: number, modeInfo?: IChatRequestModeInfo, chatAgent?: IChatAgentData, slashCommand?: IChatAgentCommand, confirmation?: string, locationData?: IChatLocationData, attachments?: IChatRequestVariableEntry[], isCompleteAddedRequest?: boolean, modelId?: string, userSelectedTools?: UserSelectedTools, id?: string): ChatRequestModel {
+	addRequest(message: IParsedChatRequest, variableData: IChatRequestVariableData, attempt: number, modeInfo?: IChatRequestModeInfo, chatAgent?: IChatAgentData, slashCommand?: IChatAgentCommand, confirmation?: string, locationData?: IChatLocationData, attachments?: IChatRequestVariableEntry[], isCompleteAddedRequest?: boolean, modelId?: string, userSelectedTools?: UserSelectedTools, id?: string, isImplicit?: boolean): ChatRequestModel {
 		const editedFileEvents = [...this.currentEditedFileEvents.values()];
 		this.currentEditedFileEvents.clear();
 		const request = new ChatRequestModel({
@@ -2561,6 +2567,7 @@ export class ChatModel extends Disposable implements IChatModel {
 			modelId,
 			editedFileEvents: editedFileEvents.length ? editedFileEvents : undefined,
 			userSelectedTools,
+			isImplicit,
 		});
 		request.response = new ChatResponseModel({
 			responseContent: [],
@@ -2718,6 +2725,7 @@ export class ChatModel extends Disposable implements IChatModel {
 					editedFileEvents: r.editedFileEvents,
 					modelId: r.modelId,
 					modeInfo: r.modeInfo,
+					isImplicit: r.isImplicit || undefined,
 					...r.response?.toJSON(),
 				};
 			}),

src/vs/workbench/contrib/chat/common/model/chatSessionOperationLog.ts

@@ -151,6 +151,7 @@ const requestSchema = Adapt.object<IChatRequestModel, ISerializableChatRequestDa
 	codeCitations: Adapt.v(m => m.response?.codeCitations, objectsEqual),
 	timeSpentWaiting: Adapt.v(m => m.response?.timestamp), // based on response timestamp
 	modeInfo: Adapt.v(m => m.modeInfo, objectsEqual),
+	isImplicit: Adapt.v(m => m.isImplicit),
 }, {
 	sealed: (o) => o.modelState?.value === ResponseModelState.Cancelled || o.modelState?.value === ResponseModelState.Failed || o.modelState?.value === ResponseModelState.Complete,
 });

src/vs/workbench/contrib/chat/common/model/chatViewModel.ts

@@ -98,6 +98,7 @@ export interface IChatRequestViewModel {
 	readonly timestamp: number;
 	/** The kind of pending request, or undefined if not pending */
 	readonly pendingKind?: ChatRequestQueueKind;
+	readonly isImplicit?: boolean;
 }
 
 export interface IChatResponseMarkdownRenderData {
@@ -334,7 +335,16 @@ export class ChatViewModel extends Disposable implements IChatViewModel {
 	}
 
 	getItems(): (IChatRequestViewModel | IChatResponseViewModel | IChatPendingDividerViewModel)[] {
-		let items: (IChatRequestViewModel | IChatResponseViewModel | IChatPendingDividerViewModel)[] = this._items.filter((item) => !item.shouldBeRemovedOnSend || item.shouldBeRemovedOnSend.afterUndoStop);
+		let items: (IChatRequestViewModel | IChatResponseViewModel | IChatPendingDividerViewModel)[] = this._items.filter((item) => {
+			if (item.shouldBeRemovedOnSend && !item.shouldBeRemovedOnSend.afterUndoStop) {
+				return false;
+			}
+			// Hide implicit requests (system-initiated notifications like terminal completions)
+			if (isRequestVM(item) && item.isImplicit) {
+				return false;
+			}
+			return true;
+		});
 		if (this._options?.maxVisibleItems !== undefined && items.length > this._options.maxVisibleItems) {
 			items = items.slice(-this._options.maxVisibleItems);
 		}
@@ -345,10 +355,11 @@ export class ChatViewModel extends Disposable implements IChatViewModel {
 			const steeringRequests = pendingRequests.filter(p => p.kind === ChatRequestQueueKind.Steering);
 			const queuedRequests = pendingRequests.filter(p => p.kind === ChatRequestQueueKind.Queued);
 
-			// Add steering requests with their divider first
-			if (steeringRequests.length > 0) {
+			// Add steering requests with their divider first (skip implicit ones)
+			const visibleSteeringRequests = steeringRequests.filter(p => !p.request.isImplicit);
+			if (visibleSteeringRequests.length > 0) {
 				items.push({ kind: 'pendingDivider', id: 'pending-divider-steering', sessionResource: this._model.sessionResource, isComplete: true, dividerKind: ChatRequestQueueKind.Steering, currentRenderedHeight: undefined });
-				for (const pending of steeringRequests) {
+				for (const pending of visibleSteeringRequests) {
 					const requestVM = this.instantiationService.createInstance(ChatRequestViewModel, pending.request, pending.kind);
 					items.push(requestVM);
 				}
@@ -477,6 +488,10 @@ export class ChatRequestViewModel implements IChatRequestViewModel {
 		return this._pendingKind;
 	}
 
+	get isImplicit() {
+		return this._model.isImplicit;
+	}
+
 	constructor(
 		private readonly _model: IChatRequestModel,
 		private readonly _pendingKind?: ChatRequestQueueKind,

src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts

@@ -1807,6 +1807,7 @@ export class RunInTerminalTool extends Disposable implements IToolImpl {
 
 			this._chatService.sendRequest(chatSessionResource, message, {
 				queue: ChatRequestQueueKind.Steering,
+				isImplicit: true,
 			}).catch(e => {
 				this._logService.warn(`RunInTerminalTool: Failed to send completion notification for terminal ${termId}`, e);
 			});