Skip to content

Commit 5852fc7

Browse files
Fix #308421: Use terminal theme background for composition view instead of hardcoded black
- Replace hardcoded black background (#000) in .xterm .composition-view with CSS variable - Now uses var(--vscode-terminal-background) to respect terminal color theme - Fallback to panel background, then hardcoded black if variables unavailable - Fixes black background appearing after space character in terminal - Affects IME composition view and applies consistently across all terminal themes - Resolves issue on Windows PowerShell and other shells with IME input
1 parent 20a513f commit 5852fc7

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • src/vs/workbench/contrib/terminal/browser/media

src/vs/workbench/contrib/terminal/browser/media/xterm.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@
8181
}
8282

8383
.xterm .composition-view {
84-
/* TODO: Composition position got messed up somewhere */
85-
background: #000;
84+
/* Use terminal theme background instead of hardcoded black to prevent black background from showing after spaces */
85+
background: var(--vscode-terminal-background, var(--vscode-panel-background, #000));
8686
color: #FFF;
8787
display: none;
8888
position: absolute;

0 commit comments

Comments
 (0)