prevent right prompt from being considered ghost text (#269732)

fix #269730

Author: meganrogge

src/vs/platform/terminal/common/capabilities/commandDetection/promptInputModel.ts

@@ -546,6 +546,11 @@ export class PromptInputModel extends Disposable implements IPromptInputModel {
 		// Retrieve the positions of all cells with the same style as `lastNonWhitespaceCell`
 		const positionsWithGhostStyle = styleMap.get(this._getCellStyleAsString(lastNonWhitespaceCell));
 		if (positionsWithGhostStyle) {
+			// Ghost text must start at the cursor or one char after (e.g. a space),
+			// preventing right-prompt styles from being misdetected as ghost text.
+			if (positionsWithGhostStyle[0] > buffer.cursorX + 1) {
+				return -1;
+			}
 			// Ensure these positions are contiguous
 			for (let i = 1; i < positionsWithGhostStyle.length; i++) {
 				if (positionsWithGhostStyle[i] !== positionsWithGhostStyle[i - 1] + 1) {

src/vs/platform/terminal/test/common/capabilities/commandDetection/promptInputModel.test.ts

@@ -215,9 +215,6 @@ suite('PromptInputModel', () => {
 
 			await writePromise('foo\x1b[38;2;255;0;0m bar\x1b[0m\x1b[4D');
 			await assertPromptInput('foo|[ bar]');
-
-			await writePromise('\x1b[2D');
-			await assertPromptInput('f|oo[ bar]');
 		});
 		test('no ghost text when foreground color matches earlier text', async () => {
 			await writePromise('$ ');

src/vs/workbench/contrib/terminal/test/browser/xterm/recordings/basic/macos_zsh_p10k_ls_one_time.ts

@@ -35,7 +35,7 @@ export const events = [
 	},
 	{
 		"type": "promptInputChange",
-		"data": "|                                                                                                     [─╯]"
+		"data": "|                                                                                                     ─╯"
 	},
 	{
 		"type": "input",
@@ -47,7 +47,7 @@ export const events = [
 	},
 	{
 		"type": "promptInputChange",
-		"data": "l|                                                                                                    [─╯]"
+		"data": "l|                                                                                                    ─╯"
 	},
 	{
 		"type": "input",
@@ -59,7 +59,7 @@ export const events = [
 	},
 	{
 		"type": "promptInputChange",
-		"data": "ls|                                                                                                   [─╯]"
+		"data": "ls|                                                                                                   ─╯"
 	},
 	{
 		"type": "input",
@@ -71,7 +71,7 @@ export const events = [
 	},
 	{
 		"type": "promptInputChange",
-		"data": "ls                                                                                                   "
+		"data": "ls                                                                                                   ─╯"
 	},
 	{
 		"type": "output",

src/vs/workbench/contrib/terminal/test/browser/xterm/recordings/rich/windows11_pwsh7_echo_3_times.ts

@@ -324,7 +324,7 @@ export const events = [
 	},
 	{
 		"type": "promptInputChange",
-		"data": "echo b|[]"
+		"data": "echo b|"
 	},
 	{
 		"type": "output",
@@ -491,7 +491,7 @@ export const events = [
 	},
 	{
 		"type": "promptInputChange",
-		"data": "echo c|[]"
+		"data": "echo c|"
 	},
 	{
 		"type": "output",