Fix terminal cursor position onPtyHostRestart#307212
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Windows terminal cursor misalignment after a pty host restart (notably with ConPTY/PSReadLine), by emitting additional cursor-positioning escape sequences alongside the restart message before relaunching the terminal.
Changes:
- On
onPtyHostRestart, append Windows-specific\r\npadding andESC[Hto align the viewport/cursor before relaunch. - Keep the existing relaunch flow and user-facing restart message, but adjust the emitted data payload.
…er.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot /review |
dmitrivMS
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #304257
Test by running command
Restart Pty hostwithterminal.integrated.windowsUseConptyDllenabled on Windows, make sure as you type the cursor position is aligned with your prompt as expected.ptyRestartFix.mp4
/cc @meganrogge