Skip to content

Fix Browser View not found #307228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jruales wants to merge 1 commit into from
Closed

Fix Browser View not found #307228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/vs/workbench/contrib/browserView/common/browserView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,9 @@ export class BrowserViewModel extends Disposable implements IBrowserViewModel {

async setVisible(visible: boolean): Promise<void> {
this._visible = visible; // Set optimistically so model is in sync immediately
if (this._store.isDisposed) {
return;
}
Comment on lines 441 to +444
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setVisible updates the model state (this._visible = visible) before checking this._store.isDisposed. If setVisible is invoked after disposal, this still mutates the model even though the service call is skipped, which can leave observers with an inconsistent visible value. Consider returning early before changing _visible, or otherwise ensure disposed instances cannot be observed/used after disposal (e.g. clear listeners / avoid calling setVisible on disposed models).

Suggested change
this._visible = visible; // Set optimistically so model is in sync immediately
if (this._store.isDisposed) {
return;
}
if (this._store.isDisposed) {
return;
}
this._visible = visible; // Set optimistically so model is in sync immediately

Copilot uses AI. Check for mistakes.
return this.browserViewService.setVisible(this.id, visible);
}

Expand Down
Loading