Fix --prof-startup never being able to profile renderer/extension host#307849
Open
winstliu wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix --prof-startup never being able to profile renderer/extension host#307849winstliu wants to merge 1 commit intomicrosoft:mainfrom
winstliu wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
@deepak1556Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes --prof-startup startup profiling by ensuring Electron/Node debug-related CLI switches are passed in the format they actually accept, so renderer and extension host profiling can attach successfully.
Changes:
- Pass
--remote-debugging-portas a port-only value (no host). - Pass
--inspect-brk-extensionsas a port-only value (no host), matchingparseDebugParamsbehavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--remote-debugging-portis documented as only accepting a port.Similarly,
--inspect-brk-extensionsruns throughparseDebugParams, which directly tries to convert the argument into a number.So, remove the host from both arguments.