perf: fix memory leaks, improve build performance, and optimize compi…#307853
Open
InSelfControll wants to merge 1 commit intomicrosoft:mainfrom
Open
perf: fix memory leaks, improve build performance, and optimize compi…#307853InSelfControll wants to merge 1 commit intomicrosoft:mainfrom
InSelfControll wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…lation Memory Leak Fixes: - Fix _instanceDisposables leak in TerminalGroup.dispose() - event listener disposables were never cleaned up when terminal groups were disposed - Fix _backgroundedTerminalDisposables leak in TerminalService - added override dispose() to clean up background terminal disposables - Fix terminal link cache leak in ExtHostTerminalService._onProcessExit() - _terminalLinkCache and _terminalLinkCancellationSource were never cleaned up when terminals exited - Add LRU eviction to ExtHostChatContext._globalItems - capped at 10,000 items to prevent unbounded memory growth from AI chat context items - Convert IDisposable[] to DisposableStore in notebook.contribution.ts (CellInfoContentProvider and NotebookMetadataContentProvider) for more robust disposal patterns Build Performance Fixes (x64/x86 compilation speed): - Enable TypeScript incremental compilation in tsconfig.json and tsconfig.base.json - expected 50-70% faster recompilation - Add npm_config_jobs=max for native module compilation in postinstall.ts - allows node-gyp to use all CPU cores during native addon builds - Increase gulp memory limit from 8GB to 16GB in package.json to reduce GC thrashing during large builds - Add rspack splitChunks optimization with vendor and common cache groups - Add vite production optimizations: esbuild minification, sourcemaps, and manual chunk splitting for vendor/xterm dependencies
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory Leak Fixes:
Build Performance Fixes (x64/x86 compilation speed):