Skip to content

Add support for code page 857 (Turkish DOS)#307888

Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c:fix/add-cp857-encoding
Open

Add support for code page 857 (Turkish DOS)#307888
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c:fix/add-cp857-encoding

Conversation

@yogeshwaran-c
Copy link
Copy Markdown
Contributor

Summary

Adds CP 857 (Turkish DOS) to the list of supported document encodings in SUPPORTED_ENCODINGS.

CP 857 was widely used for Turkish text in legacy DOS/Windows environments and is still present in many legacy projects today. It was already supported in the integrated terminal (terminalEncoding.ts) but was missing from the document encoding list, which appears to have been an unintentional omission.

Fixes #300041

Test plan

  • Open a file saved with CP 857 encoding
  • Use "Change File Encoding" / "Reopen with Encoding" command and verify "Turkish DOS (CP 857)" appears in the encoding picker
  • Verify selecting CP 857 correctly decodes Turkish characters in the file

Adds CP 857 to the list of supported document encodings. This codepage
was widely used for Turkish text in legacy DOS/Windows environments and
is still present in many legacy projects. It was already supported in
the integrated terminal but missing from the document encoding list.

Fixes microsoft#300041

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/services/textfile/common/encoding.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CP857 is missing in supported document encodings

2 participants