Add package.json catalog support for npm completions and hover#307989
Open
yogeshwaran-c wants to merge 2 commits intomicrosoft:mainfrom
Open
Add package.json catalog support for npm completions and hover#307989yogeshwaran-c wants to merge 2 commits intomicrosoft:mainfrom
yogeshwaran-c wants to merge 2 commits intomicrosoft:mainfrom
Conversation
e63ecff to
a2472a9
Compare
Contributor
|
Are unrelated changes to AI instruction files. Please remove these. |
aeschli
requested changes
Apr 7, 2026
Contributor
There was a problem hiding this comment.
Should not be included in this PR.
Extend the npm extension to recognize the `catalog` section in package.json, enabling IntelliSense completions, version suggestions, and hover information for packages listed under the catalog key. This supports the catalog feature used by pnpm, bun, and yarn for centralizing dependency versions in monorepos. Fixes microsoft#294609
a2472a9 to
c43386c
Compare
Contributor
Author
|
Removed the unrelated AI instruction files. PR now only contains the npm catalog change (1 file, 3 lines). |
aeschli
approved these changes
Apr 8, 2026
alexdima
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catalogsection inpackage.json, enabling IntelliSense completions, version suggestions, and hover information for packages listed under the catalog keylocation.matches(['catalog'])andlocation.matches(['catalog', '*'])to the three relevant methods inpackageJSONContribution.ts:collectPropertySuggestions,collectValueSuggestions, andgetInfoContributionFixes #294609
Test plan
package.jsonfile that contains acatalogsection (e.g., a pnpm workspace root)"catalog": { }triggers npm package name completionscatalogsection shows package description, latest version, and homepagedependencies,devDependencies,optionalDependencies, andpeerDependenciesbehavior is unchanged