Skip to content

Add package.json catalog support for npm completions and hover #307989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yogeshwaran-c wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Add package.json catalog support for npm completions and hover #307989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c43386c
Add package.json catalog support for npm completions and hover
yogeshwaran-c Apr 6, 2026
b7c5f13
Merge branch 'main' into feat/npm-catalog-support
aeschli Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions extensions/npm/src/features/packageJSONContribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class PackageJSONContribution implements IJSONContribution {
return null;
}

if ((location.matches(['dependencies']) || location.matches(['devDependencies']) || location.matches(['optionalDependencies']) || location.matches(['peerDependencies']))) {
if ((location.matches(['dependencies']) || location.matches(['devDependencies']) || location.matches(['optionalDependencies']) || location.matches(['peerDependencies']) || location.matches(['catalog']))) {
let queryUrl: string;
if (currentWord.length > 0) {
if (currentWord[0] === '@') {
Expand Down Expand Up @@ -184,7 +184,7 @@ export class PackageJSONContribution implements IJSONContribution {
return null;
}

if ((location.matches(['dependencies', '*']) || location.matches(['devDependencies', '*']) || location.matches(['optionalDependencies', '*']) || location.matches(['peerDependencies', '*']))) {
if ((location.matches(['dependencies', '*']) || location.matches(['devDependencies', '*']) || location.matches(['optionalDependencies', '*']) || location.matches(['peerDependencies', '*']) || location.matches(['catalog', '*']))) {
const currentKey = location.path[location.path.length - 1];
if (typeof currentKey === 'string') {
const info = await this.fetchPackageInfo(currentKey, resource);
Expand Down Expand Up @@ -347,7 +347,7 @@ export class PackageJSONContribution implements IJSONContribution {
if (!this.isEnabled()) {
return null;
}
if ((location.matches(['dependencies', '*']) || location.matches(['devDependencies', '*']) || location.matches(['optionalDependencies', '*']) || location.matches(['peerDependencies', '*']))) {
if ((location.matches(['dependencies', '*']) || location.matches(['devDependencies', '*']) || location.matches(['optionalDependencies', '*']) || location.matches(['peerDependencies', '*']) || location.matches(['catalog', '*']))) {
const pack = location.path[location.path.length - 1];
if (typeof pack === 'string') {
return this.fetchPackageInfo(pack, resource).then(info => {
Expand Down