guard installing built in extensions in cli#308967
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a CLI-side guard to prevent installing/updating certain built-in extensions when the current product quality disallows those updates (as indicated by builtInExtensionsEnabledWithAutoUpdates combined with forceAutoUpdate).
Changes:
- Block gallery-based installs/updates when the target is already installed as a built-in extension that is not permitted to update in the current product quality.
- Apply the same restriction to VSIX installs by validating against the already-installed extension list.
- Introduce a shared helper to compute/log the “blocked” message.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/extensionManagement/common/extensionManagementCLI.ts | Adds validations to stop CLI installs/updates of restricted built-in extensions (gallery + VSIX paths). |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
jrieken
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.