Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an “aquarium” animation overlay to the Agents window new-session screen, with a persistent toggle button in the chat bar and animated VS Code-logo “fish”/food interactions.
Changes:
- Registers a new sessions workbench contribution that mounts an aquarium overlay and toggle button (AfterRestored).
- Implements animated fish/food/water layers and supporting SVG generation + styling.
- Adds supporting context key, i18n resource mapping, and stylelint allowlisting for new CSS variables.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/sessions.common.main.ts | Loads the new aquarium contribution in the sessions workbench entrypoint. |
| src/vs/sessions/contrib/aquarium/browser/aquarium.contribution.ts | Registers the aquarium workbench contribution and instantiates the overlay. |
| src/vs/sessions/contrib/aquarium/browser/aquariumOverlay.ts | Implements overlay lifecycle, DOM layers, interactions, and RAF-driven animation loop. |
| src/vs/sessions/contrib/aquarium/browser/fish.ts | Builds fish DOM/SVG (strip-clipped VS Code logo) and shared SVG defs. |
| src/vs/sessions/contrib/aquarium/browser/media/aquarium.css | Adds water/fish/food/toggle styling, animations, and reduced-motion handling. |
| src/vs/sessions/common/contextkeys.ts | Introduces sessionsAquariumActive context key. |
| build/lib/stylelint/vscode-known-variables.json | Allowlists new CSS custom properties used by the aquarium feature. |
| build/lib/i18n.resources.json | Adds a sessions i18n project mapping for vs/sessions/contrib/aquarium. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/sessions/contrib/aquarium/browser/aquariumOverlay.ts:343
- Food drops are wired to
EventType.MOUSE_DOWN. On iOS this event doesn’t fire (pointer events are used), so users won’t be able to drop food. Please useaddDisposableGenericMouseDownListener(or pointer events) for cross-platform input.
store.add(addDisposableListener(mainContainer, EventType.MOUSE_DOWN, (e: MouseEvent) => {
// Only spawn food on plain left clicks against background-ish surfaces.
if (e.button !== 0) {
return;
}
- Files reviewed: 8/8 changed files
- Comments generated: 7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aquarium animation on agent new sessions screen
Screen.Recording.2026-04-26.at.4.33.32.PM.mov