Skip to content

aquarium?#312642

Draft
justschen wants to merge 2 commits intomainfrom
justin/goomy
Draft

aquarium?#312642
justschen wants to merge 2 commits intomainfrom
justin/goomy

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

aquarium animation on agent new sessions screen

Screen.Recording.2026-04-26.at.4.33.32.PM.mov

Copilot AI review requested due to automatic review settings April 26, 2026 23:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an “aquarium” animation overlay to the Agents window new-session screen, with a persistent toggle button in the chat bar and animated VS Code-logo “fish”/food interactions.

Changes:

  • Registers a new sessions workbench contribution that mounts an aquarium overlay and toggle button (AfterRestored).
  • Implements animated fish/food/water layers and supporting SVG generation + styling.
  • Adds supporting context key, i18n resource mapping, and stylelint allowlisting for new CSS variables.
Show a summary per file
File Description
src/vs/sessions/sessions.common.main.ts Loads the new aquarium contribution in the sessions workbench entrypoint.
src/vs/sessions/contrib/aquarium/browser/aquarium.contribution.ts Registers the aquarium workbench contribution and instantiates the overlay.
src/vs/sessions/contrib/aquarium/browser/aquariumOverlay.ts Implements overlay lifecycle, DOM layers, interactions, and RAF-driven animation loop.
src/vs/sessions/contrib/aquarium/browser/fish.ts Builds fish DOM/SVG (strip-clipped VS Code logo) and shared SVG defs.
src/vs/sessions/contrib/aquarium/browser/media/aquarium.css Adds water/fish/food/toggle styling, animations, and reduced-motion handling.
src/vs/sessions/common/contextkeys.ts Introduces sessionsAquariumActive context key.
build/lib/stylelint/vscode-known-variables.json Allowlists new CSS custom properties used by the aquarium feature.
build/lib/i18n.resources.json Adds a sessions i18n project mapping for vs/sessions/contrib/aquarium.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/sessions/contrib/aquarium/browser/aquariumOverlay.ts:343

  • Food drops are wired to EventType.MOUSE_DOWN. On iOS this event doesn’t fire (pointer events are used), so users won’t be able to drop food. Please use addDisposableGenericMouseDownListener (or pointer events) for cross-platform input.
	store.add(addDisposableListener(mainContainer, EventType.MOUSE_DOWN, (e: MouseEvent) => {
		// Only spawn food on plain left clicks against background-ish surfaces.
		if (e.button !== 0) {
			return;
		}
  • Files reviewed: 8/8 changed files
  • Comments generated: 7

Comment thread build/lib/stylelint/vscode-known-variables.json Outdated
Comment thread src/vs/sessions/contrib/aquarium/browser/aquariumOverlay.ts Outdated
Comment thread src/vs/sessions/contrib/aquarium/browser/aquariumOverlay.ts Outdated
Comment thread src/vs/sessions/contrib/aquarium/browser/aquariumOverlay.ts Outdated
Comment thread src/vs/sessions/contrib/aquarium/browser/media/aquarium.css Outdated
Comment thread src/vs/sessions/contrib/aquarium/browser/fish.ts Outdated
Comment thread src/vs/sessions/contrib/aquarium/browser/fish.ts
@justschen justschen requested a review from Copilot April 27, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants