Skip to content

sessions: ensure account/update widgets render with icons #312645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osortega merged 1 commit into from
Apr 27, 2026
+4 −13
Merged

sessions: ensure account/update widgets render with icons #312645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions src/vs/sessions/contrib/accountMenu/browser/account.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,16 +757,9 @@ class TitleBarUpdateWidget extends BaseActionViewItem {

// --- Register custom view item --- //

// These actions are registered at module level (not lazily inside AccountWidgetContribution)
// so that Menus.TitleBarRightLayout is non-empty when the MenuWorkbenchToolBar is first
// constructed. If they were registered lazily (WorkbenchPhase.AfterRestored), the toolbar's
// IntersectionObserver would have already observed an empty, display:none container and
// stopped listening for menu changes — causing the widgets to never appear.
//
// The actual widget rendering and interaction is handled by TitleBarUpdateWidget /
// TitleBarAccountWidget, which are custom view items registered via IActionViewItemService
// in AccountWidgetContribution. Those widgets attach their own DOM click handlers, so
// run() here is intentionally a no-op.
// Actions registered at module level so Menus.TitleBarRightLayout is non-empty when the
// toolbar is first constructed. The run() is a no-op — rendering is handled by the custom
// view items registered in AccountWidgetContribution.
Comment thread
osortega marked this conversation as resolved.
registerAction2(class extends Action2 {
constructor() {
super({
Expand Down Expand Up @@ -811,16 +804,14 @@ class AccountWidgetContribution extends Disposable implements IWorkbenchContribu
) {
super();

// Titlebar update widget (to the right of separator, left of account badge)
this._register(actionViewItemService.register(Menus.TitleBarRightLayout, SessionsTitleBarUpdateWidgetAction, (action, options) => {
return instantiationService.createInstance(TitleBarUpdateWidget, action, options);
}, undefined));

// Titlebar account widget (rightmost in titlebar)
this._register(actionViewItemService.register(Menus.TitleBarRightLayout, SessionsTitleBarAccountWidgetAction, (action, options) => {
return instantiationService.createInstance(TitleBarAccountWidget, action, options);
}, undefined));
}
}

registerWorkbenchContribution2(AccountWidgetContribution.ID, AccountWidgetContribution, WorkbenchPhase.AfterRestored);
registerWorkbenchContribution2(AccountWidgetContribution.ID, AccountWidgetContribution, WorkbenchPhase.BlockRestore);
Loading